Closed Bug 1600979 Opened 6 years ago Closed 6 years ago

Ignore exceptions from getFrames call when thread context is invalid

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

Bug 1600979 - Ignore exceptions from getFrames call when thread context is invalid, r=jlast.
47 bytes, text/x-phabricator-request
Details | Review
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/55171ff3d0f3 Ignore exceptions from getFrames call when thread context is invalid, r=jlast.

Backed out changeset 55171ff3d0f3 (bug 1600979) for devtools failures at devtools/client/debugger/test/mochitest/browser_dbg-event-breakpoints.js

Backout: https://hg.mozilla.org/integration/autoland/rev/1434f6824ecca55ba088e6ef2f2fe3aa29af3c45

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=55171ff3d0f3b271dbac9f4defec583a84fce192

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279582918&repo=autoland&lineNumber=8378

task 2019-12-04T15:54:25.512Z] 15:54:25 INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-event-breakpoints.js | The main process DebuggerServer has no pending connection when the test ends -
[task 2019-12-04T15:54:25.512Z] 15:54:25 INFO - Console message: [JavaScript Error: "Error: Thread context is still valid" {file: "resource://devtools/client/debugger/src/actions/pause/fetchFrames.js" line: 30}]
[task 2019-12-04T15:54:25.512Z] 15:54:25 INFO - Buffered messages finished
[task 2019-12-04T15:54:25.512Z] 15:54:25 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-event-breakpoints.js | A promise chain failed to handle a rejection: Thread context is still valid - stack: fetchFrames/<@resource://devtools/client/debugger/src/actions/pause/fetchFrames.js:30:15
[task 2019-12-04T15:54:25.512Z] 15:54:25 INFO - asyncthunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2019-12-04T15:54:25.512Z] 15:54:25 INFO - dispatch@resource://devtools/client/shared/vendor/redux.js:755:18
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - paused/<@resource://devtools/client/debugger/src/actions/pause/paused.js:51:11
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - bindActionCreator/<@resource://devtools/client/shared/vendor/redux.js:644:12
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - paused@resource://devtools/client/debugger/src/client/firefox/events.js:91:11
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - Asyncemit@resource://devtools/shared/event-emitter.js:190:24
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - emit@resource://devtools/shared/event-emitter.js:271:18
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - onPacket@resource://devtools/shared/protocol/Front.js:252:13
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - onPacket@resource://devtools/shared/client/debugger-client.js:511:13
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - send/<@resource://devtools/shared/transport/local-transport.js:70:25
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - DevToolsUtils.executeSoonexports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - send@resource://devtools/shared/transport/local-transport.js:58:21
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - send@resource://devtools/server/debugger-server-connection.js:89:20
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - receiveMessage@resource://devtools/shared/transport/child-transport.js:66:16
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - MessageListener.receiveMessage_addListener@resource://devtools/shared/transport/child-transport.js:40:14
[task 2019-12-04T15:54:25.513Z] 15:54:25 INFO - ready@resource://devtools/shared/transport/child-transport.js:57:10
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - connectToFrame/</onActorCreated<@resource://devtools/server/connectors/frame-connector.js:183:22
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - MessageListener.receiveMessagetrackMessageManager@resource://devtools/server/connectors/frame-connector.js:55:12
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - connectToFrame/<@resource://devtools/server/connectors/frame-connector.js:283:5
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - connectToFrame@resource://devtools/server/connectors/frame-connector.js:41:10
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - connect@resource://devtools/server/actors/targets/frame-proxy.js:65:35
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - asyncBrowserTabList.prototype._getActorForBrowser@resource://devtools/server/actors/webbrowser.js:368:16
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - BrowserTabList.prototype.getTab@resource://devtools/server/actors/webbrowser.js:410:21
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - onGetTab@resource://devtools/server/actors/root.js:342:35
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - onPacket@resource://devtools/server/debugger-server-connection.js:378:58
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - send/<@resource://devtools/shared/transport/local-transport.js:70:25
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - DevToolsUtils.executeSoonexports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - send@resource://devtools/shared/transport/local-transport.js:58:21
[task 2019-12-04T15:54:25.514Z] 15:54:25 INFO - send@resource://devtools/shared/protocol/Front.js:198:30
[task 2019-12-04T15:54:25.515Z] 15:54:25 INFO - request@resource://devtools/shared/protocol/Front.js:216:10
[task 2019-12-04T15:54:25.515Z] 15:54:25 INFO - generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:49:19
[task 2019-12-04T15:54:25.515Z] 15:54:25 INFO - getTab@resource://devtools/shared/fronts/root.js:380:30
[task 2019-12-04T15:54:25.515Z] 15:54:25 INFO - createTargetForTab@resource://devtools/client/framework/target.js:100:28
[task 2019-12-04T15:54:25.515Z] 15:54:25 INFO - asyncforTab@resource://devtools/client/framework/target.js:42:26

Flags: needinfo?(bhackett1024)
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/731e7b07c8d2 Ignore exceptions from getFrames call when thread context is invalid, r=jlast.

https://hg.mozilla.org/mozilla-central/rev/731e7b07c8d2

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Flags: needinfo?(bhackett1024)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: