1601023 - Handle "install-certificate" inline with original command

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement, P3)

Description

[Mitchell Hentges [:mhentges] 🦀]

Right now, if I attempt to moz-phab a patch but I don't have an API key yet, moz-phab will throw an error and tell me to run moz-phab install-certificate.

However, perhaps we should automatically run the install-certificate workflow, then retry pushing the commit. There's already precedent for this, since if your moz-phab is out-of-date, it automatically updates then performs the command (instead of erroring and telling you to moz-phab self-update)

Comment 1

[Piotr Zalewa [:zalun]]

We're following the Arcanist workflow.
I remember having this conversation with glob, but not the actual reason we've decided to not do it automatically.

Comment 2

[:glob ✱]

I can't think of any reason why we couldn't do it automatically.

Comment 3

[Graham Robertson [:grammar]]

Attachment: Bug 1601023 - automatically install new api token when not present r?sheehan

Depends on D152560