1601026 - Some WPT tests for ::marker use non-allowed properties

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Description

[Oriol Brufau [:Oriol]]

See https://wpt.fyi/results/css/css-pseudo?label=master&label=experimental&aligned&q=marker-content%20firefox%3Afail

There are 4 WPT tests for ::marker that are failing:

• marker-content-007.html
• marker-content-008.html
• marker-content-009.html
• marker-content-011.html

That's because they use properties like writing-mode or display inside ::marker, which is not currently allowed by css-pseudo.

I understand that you may want to keep these tests since you have the layout.css.marker.restricted pref to lift the restriction.

But having these tests in WPT seems wrong. Can't you move them outside of WPT and make them Mozilla-internal? Or at least add "tentative" in the name or something.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1601026 - Mark some marker tests as tentative. r=oriol

They use properties like writing-mode or display inside ::marker, which is not
currently allowed by css-pseudo.

Comment 2

[Mats Palmgren (inactive)]

I think these styling restrictions on ::marker should be removed. There are no technical reasons for why ::marker shouldn't accept everything that ::before/::after accepts (with a few exceptions like float/position on outside markers perhaps). I really don't understand why the CSSWG intentionally cripples a feature like this.

Comment 3

[Oriol Brufau [:Oriol]]

(In reply to Mats Palmgren (:mats) from comment #2)

I think these styling restrictions on ::marker should be removed. There are no technical reasons for why ::marker shouldn't accept everything that ::before/::after accepts (with a few exceptions like float/position on outside markers perhaps). I really don't understand why the CSSWG intentionally cripples a feature like this.

Well, without the restrictions it was easy to trigger assert failures in Chromium e.g. with display: none, so it's simpler this way :)
But I agree that it doesn't make much sense for inherited properties, since you can set them in the list item anyways...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f38d2fd983
Mark some marker tests as tentative. r=Oriol

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20599 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/20599
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/YoOhfpj0Q7299lxScE_E4A)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Commented there, not my issue.

Comment 8

[Mats Palmgren (inactive)]

Well, without the restrictions it was easy to trigger assert failures in Chromium e.g. with display: none, so it's simpler this way :)

That's clearly a Chromium problem and not something that the CSSWG should care about when writing its standards. :-p

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d0f38d2fd983

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot