1601040 - Add UI for modifying resistFingerprinting prefs when privacy.resistFingerprinting is enabled

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, enhancement)

Description

[morgan (Tor Project)]

Tor Browser issue https://trac.torproject.org/projects/tor/ticket/32325

We'd like to allow users to enable or disable letterboxing without having to navigate about:config. Arthur suggested adding UI to about:preferences that is hidden when the base privacy.resistFingerprinting pref is disabled so that the option does not appear by default.

Comment 1

[morgan (Tor Project)]

Attachment: Bug 1601040

Adds UI to about:preferences#privacy to toggle letterboxing, but only if privacy.resistFingerprinting is enabled.

Patch originally written against ESR68, but gecko-dev/master crashes on boot ( I seem to be hitting https://bugzilla.mozilla.org/show_bug.cgi?id=1538435 ) but hopefully this patch works.

Comment 2

[morgan (Tor Project)]

Attachment: Bug 1601040: Changed patch on initial feedback

ignore this sorry

Comment 3

[morgan (Tor Project)]

Attachment: Bug 1601040: initial patch

Comment 4

[morgan (Tor Project)]

Attachment: Bug 1601040 - Add UI to about:preferences for enabling letterboxing when privacy.resistFingerprinting pref is enabled

• put the preference XML in an inner groupbox and hide/unhide
  that rather than using custom css

Comment 5

[morgan (Tor Project)]

Hi bmikel,

We need to update the proposed copy for this feature.

We would like to expose an option in about:preferences#privacy to enable/disable the letterboxing resist-fingerprinting feature. This will be enabled by default in Tor Browser and we would like to discourage users from disabling it. The option will be not be visible or enabled in vanilla Firefox.

The Tor Browser ticket with some background info can be found here: https://trac.torproject.org/projects/tor/ticket/32325

Comment 6

[morgan (Tor Project)]

bmikel: just pinging you on this.

Comment 7

[Betsy Mikel [:betsymi]]

Discussed with Arthur. I am clearing the need info for myself, as it sounds like some conversation needs to happen about the correct approach.

Comment 8

[Thorin [:thorin]]

I think LBing should first be made dependent on RFP=true. For TB this is not a problem, as RFP is enforced. but this is not the case for Firefox. And by that, I don't mean the UI option being displayed, I mean the LBing functionality itself.

example: FF user:

• turns on RFP (someone recommended it)
• goes to the UI option and enables LB (because it's there)
• at some stage gets annoyed by RFP's timezone, so he disables RFP (someone on reddit told him to do it)
• now he's stuck with LBing and no UI (he has no idea what the pref is)

It doesn't even make sense to have LBing but not RFP, and could actually be quite telling (FPing likes stability)

Comment 9

[Tom Ritter [:tjr] (OOTO until 9/2)]

Tor doesn't add this UI anymore; right? So this is WONTFIX?

Comment 10

[morgan (Tor Project)]

Yes it seems like we don't do this anymore.