1601080 - When opening an updated build after 4AM, the "metrics" ping is sent with the previous build's metrics but the current' build's client_info.

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P3)

Description

[Chris H-C :chutten]

When trying to get clients with or without a given metric in the "metrics" ping, it is difficult to slice nicely because the first "metrics" ping after updating contains the previous build's metrics but the current build's client_info.

We should bake the client_info somehow into the scheduler so that metrics from a build are associated with that build id in its "metrics" pings.

Comment 1

[Alessio Placitelli [:Dexter]]

(In reply to Chris H-C :chutten from comment #0)

When trying to get clients with or without a given metric in the "metrics" ping, it is difficult to slice nicely because the first "metrics" ping after updating contains the previous build's metrics but the current build's client_info.

We should bake the client_info somehow into the scheduler so that metrics from a build are associated with that build id in its "metrics" pings.

I think this would still make things a bit complicated: if the metrics ping gets sent after a while Fenix is running, then we end up collecting metrics from before and after the update, in the same ping.

I think we should probably do something different: what if we had a way to detect that the application was updated and cut a metrics ping at startup?

Comment 2

[Chris H-C :chutten]

That would work wonderfully well. In absence of data showing one way or another, I expect this is similar behaviour to the likely update case (app updates overnight, user opens app after 4AM) so it wouldn't really even be that much of a change.

And "having a way to detect" is closely correlated with "keeping the old *_info fields handy" we'd need to do in order to send the ping with the proper values, so that's nice : )

Comment 3

[Travis Long [:travis_]]

I think that the PR attached to Bug 1602824 actually resolves this bug too since it adds a check for new version and sends a metrics ping if there is.

Comment 4

[Michael Droettboom [:mdroettboom]]

Yep, Bug 1602824 fixed this bug!