Closed
Bug 1601088
Opened 6 years ago
Closed 6 years ago
[jsdbg2] DebugAPI::slowPathTraceGeneratorFrame has a bad comment
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox71 | --- | unaffected |
| firefox72 | --- | wontfix |
| firefox73 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
The comment above the call to TraceCrossCompartmentEdge in DebugAPI::slowPathTraceGeneratorFrame is inaccurate. As Logan notes in D53078:
edgeIsInDebuggerWeakmapverifies the edge from theDebugger.Frameto theAbstractGeneratorObject, but not the other way around. I believe this skips theedgeIsInDebuggerWeakmapentirely because the cross-compartment edge verification that callsedgeIsInDebuggerWeakmapis a callback tracer, so we return above without tracing the edge.
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d23d75ef78d
Fix DebugAPI::slowPathTraceGeneratorFrame's justification for calling TraceCrossCompartmentEdge. r=loganfsmyth
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
|
||
Updated•6 years ago
|
Keywords: regression
|
||
Updated•6 years ago
|
status-firefox71:
--- → unaffected
status-firefox72:
--- → wontfix
status-firefox-esr68:
--- → unaffected
|
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•