1601130 - about:welcome redirects to "Would you like to sync device to your account?" page when already signed into sync

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, defect, P3)

Description

[Ana Medinac]

Attachment: Screen Shot 2019-12-03 at 6.43.42 PM.png

The about:welcome page does not recognize that I am already signed into the browser, and when I try to sign in from the link, it redirects me to a sync optional flow that shows up when the user is trying to connect another device.

If you click "Don't Sync this Device" it does not turn off sync on the device.

Steps to recreate:

1. Sign into FxA and enable sync from the account toolbar.
2. Go to the about:welcome page (Variant in screenshot), and click "Already Have an Account? Sign In"
3. Sign in
4. Click "Don't sync this device"
5. Check in the sync preferences and the device is still syncing.

Should the variant redirect you to the "Would you like to sync?" page when I already have sync enabled? If yes, should we turn off sync if the user then clicks "Don't Sync this device"?

Comment 1

[Ana Medinac]

Attachment: Screen Shot 2019-12-03 at 6.43.24 PM.png

Comment 2

[Ed Lee :Mardak]

Most users only see about:welcome on first run of a new profile. How are you ending up on about:welcome?

Comment 3

[Ana Medinac]

We were testing out different flows so I returned to about:welcome and clicked already have an account. Since most, if not all, users tend to see this page on their first run with a new profile, I don't think this would happen often, I just filed a bug to document the behaviour.

Comment 4

[Vasilica Tamas, QA [:vtamas]]

Shane, isn’t this issue something that we should track also in a fxa github ? There are 2 variants of welcome page that display the “Sign in” button:

• trailhead.firstrun.branches set to full_page_d-supercharge
• trailhead.firstrun.branches set to full_page_e-supercharge

As Ana mentioned above, there are small chances for this to happen, but the result is not good at all.

Comment 5

[Vasilica Tamas, QA [:vtamas]]

Attachment: cwts3.gif

This issue also reproduces for any login from about:welcome, this means that it is also included the “Enter email” field and it is applicable for all about:welcome pages.

The only condition here is that a user must be already signed in the browser (this user can be different from the one that tries to login via about:welcome, and the first one will be replaced by the second one) and the sync must be turned on.

Comment 6

[Shane Tomlinson [:stomlinson]]

(In reply to Vasilica Tamas, QA from comment #4)

Shane, isn’t this issue something that we should track also in a fxa github ? There are 2 variants of welcome page that display the “Sign in” button:

• trailhead.firstrun.branches set to full_page_d-supercharge
• trailhead.firstrun.branches set to full_page_e-supercharge

As Ana mentioned above, there are small chances for this to happen, but the result is not good at all.

I defer to :adavis, though my feeling is that this is a pretty extreme edge case.

Comment 7

[Alex Davis [:adavis]]

This is less of an edge case if this is happening with the /whatsnew pages which should also be using the sync-optional flows AND are not currently segmenting their messaging for existing users vs non-sync users.

I would mark this as WONT FIX if we can't reproduce it elsewhere since users won't navigate to about:welcome. It can't be found anywhere.

However, if we can reproduce this in another sync-optional flow then we should certainly dig in more.

Comment 8

[Vasilica Tamas, QA [:vtamas]]

This issue is not reproducible on other sync flows. Based on Comment 7 I am marking this bug as WONT FIX.