Closed
Bug 1601171
Opened 4 years ago
Closed 4 years ago
[jsdbg2] All handlers for a Debugger hook function should be guaranteed to run, even if an early one returns termination
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
Details
Attachments
(4 files, 2 obsolete files)
onLeaveFrame has a bunch of custom logic to handle the case of onPop handlers from multiple Debugger instances returning completion values (by taking the most recent non-undefined completion), but all of the other hook implementations bail out as soon as they see the first non-undefined completion and don't run later hooks.
|
Assignee | |
Updated•4 years ago
|
Type: task → defect
|
||
Updated•4 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D57938
|
||
Updated•4 years ago
|
Assignee: nobody → loganfsmyth
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D58182
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D58183
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D58184
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D58185
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D58186
|
|
||
Updated•4 years ago
|
Attachment #9117642 -
Attachment is obsolete: true
|
|
||
Updated•4 years ago
|
Attachment #9117643 -
Attachment description: Bug 1601171 - Part 4: Do not use previous onPop completion to update the value passed to the next hook. r=jimb! → Bug 1601171 - Part 2: Do not use previous onPop completion to update the value passed to the next hook. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117641 -
Attachment is obsolete: true
|
|
||
Updated•4 years ago
|
Attachment #9117644 -
Attachment description: Bug 1601171 - Part 5: Run all debugger hooks, even if some throw uncaught exceptions. r=jimb! → Bug 1601171 - Part 3: Run all debugger hooks, even if some throw uncaught exceptions. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117645 -
Attachment description: Bug 1601171 - Part 6: Run all debugger hooks, even if some return resumption values. r=jimb! → Bug 1601171 - Part 4: Run all debugger hooks, even if some return resumption values. r=jimb!
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2918a19232e8 Part 1: Pull the frame's generator from the frame directly. r=jimb https://hg.mozilla.org/integration/autoland/rev/1e7f23870af3 Part 2: Do not use previous onPop completion to update the value passed to the next hook. r=jimb https://hg.mozilla.org/integration/autoland/rev/a9b20281ee58 Part 3: Run all debugger hooks, even if some throw uncaught exceptions. r=jimb https://hg.mozilla.org/integration/autoland/rev/59ecb73e49fc Part 4: Run all debugger hooks, even if some return resumption values. r=jimb
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2918a19232e8
https://hg.mozilla.org/mozilla-central/rev/1e7f23870af3
https://hg.mozilla.org/mozilla-central/rev/a9b20281ee58
https://hg.mozilla.org/mozilla-central/rev/59ecb73e49fc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•