1601219 - The color-picker does not work in the OBT for `color` properties in the content page

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Patrick Brosset <:pbro>]

Steps:

• navigate to any site in a Firefox tab
• open the OBT
• from the OBT's inspector panel, pick an element from the content page that has some color styles
• click on the color swatches to to open the color picker

Expected: the color picker should open up and let you edit the color

Actual: if the color swatch is for a background-color, this works fine. However if it is for a color property, then it fails and the color picker doesn't appear. The following JS error is thrown too:

Error while calling actor 'pagestyle's method 'getComputed' node is null Actor.js:91:13
getComputed@resource://devtools/server/actors/styles.js:314:5 handler@resource://devtools/shared/protocol/Actor.js:154:37 onPacket@resource://devtools/server/debugger-server-connection.js:378:58 _onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22 exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22 exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22 Actor.js:96:15

Doing the same on an element that belongs to the main browser UI works fine.

Comment 1

[Patrick Brosset <:pbro>]

I know how to fix this, and this should probably be a blocker for the DevTools fission M1 milestone. So taking it now.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug 1601219 - Use the right PageStyleFront instance when querying computed styles from the color picker; r?rcaliman!

It looks like we left out some places in the inspector when we made it fission-compatible.
The color-picker, in particular, needs access to the selected node's computed style for its
color contrast logic.
We used to access this on the top-level target PageStyleFront. We just need to change this so
it uses the one contextual to the selected node.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52cf8917115d
Use the right PageStyleFront instance when querying computed styles from the color picker; r=rcaliman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/52cf8917115d