1601228 - Split up GC.cpp into smaller chunks

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

This file is close to 9000 lines and should be split up. We talked about splitting it up based on GC phase i.e. moving code into Marking.cpp, Sweeping.cpp, Compacting.cpp.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1601228 - Move tenuring implementation to a new source file r?sfink

Splitting up GC.cpp will add more code to Marking.cpp so as a first step let's
move all the tenuring code out of Marking.cpp into its own source file.

This is all code motion, except I make MAX_DEDUPLICATABLE_STRING_LENGTH a
constant.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/106b9a0d5a91
Move tenuring implementation to a new source file r=sfink

Comment 3

[Cristian Tuns]

Backed out for causing spidermonkey and build bustages

• Backout link
• Push with failures
• Failure Log
• Failure Log build

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b47eeebcf6
Move tenuring implementation to a new source file r=sfink

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1601228 - Move compacting GC impmementation to a new source file r?sfink

This moves ~1000 lines into a new file. No code changes.

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e8b47eeebcf6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc5ae328f6f4
Move compacting GC impmementation to a new source file r=sfink

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fc5ae328f6f4

Comment 9

[Jon Coppeard (:jonco)]

Attachment: Bug 1601228 - Move heap related methods to a new source file r?sfink

Comment 10

[Jon Coppeard (:jonco)]

Attachment: Bug 1601228 - Move API methods to a new source file r?sfink

Depends on D125648

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f93f5d296b51
Move heap related methods to a new source file r=sfink
https://hg.mozilla.org/integration/autoland/rev/df8d93b99342
Move API methods to a new source file r=sfink

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f93f5d296b51
https://hg.mozilla.org/mozilla-central/rev/df8d93b99342

Comment 13

[Jon Coppeard (:jonco)]

Attachment: Bug 1601228 - Move GC sweeping implementation to a new source file r?sfink

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cc5876a51be
Move GC sweeping implementation to a new source file r=sfink

Comment 15

[Cristina Cozmuta (:CrissCozmuta)]

Backed out changeset 5cc5876a51be (Bug 1601228) for causing merge conflict a=backout
https://hg.mozilla.org/mozilla-central/rev/911336703b42dc64793ebe919fe8ab8257d8f210
Sorry for the inconvenience.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d2ad8459884
Move GC sweeping implementation to a new source file r=sfink

Comment 17

[Jon Coppeard (:jonco)]

Rebased and re-landed.

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d2ad8459884

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jonco, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.