Open Bug 1601228 Opened 2 years ago Updated 15 days ago

Split up GC.cpp into smaller chunks

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(5 files)

This file is close to 9000 lines and should be split up. We talked about splitting it up based on GC phase i.e. moving code into Marking.cpp, Sweeping.cpp, Compacting.cpp.

Assignee: nobody → jcoppeard
Keywords: leave-open

Splitting up GC.cpp will add more code to Marking.cpp so as a first step let's
move all the tenuring code out of Marking.cpp into its own source file.

This is all code motion, except I make MAX_DEDUPLICATABLE_STRING_LENGTH a
constant.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/106b9a0d5a91
Move tenuring implementation to a new source file r=sfink

Backed out for causing spidermonkey and build bustages

Flags: needinfo?(jcoppeard)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8b47eeebcf6
Move tenuring implementation to a new source file r=sfink

This moves ~1000 lines into a new file. No code changes.

Flags: needinfo?(jcoppeard)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc5ae328f6f4
Move compacting GC impmementation to a new source file r=sfink
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f93f5d296b51
Move heap related methods to a new source file r=sfink
https://hg.mozilla.org/integration/autoland/rev/df8d93b99342
Move API methods to a new source file r=sfink
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cc5876a51be
Move GC sweeping implementation to a new source file r=sfink

Backed out changeset 5cc5876a51be (Bug 1601228) for causing merge conflict a=backout
https://hg.mozilla.org/mozilla-central/rev/911336703b42dc64793ebe919fe8ab8257d8f210
Sorry for the inconvenience.

Flags: needinfo?(jcoppeard)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d2ad8459884
Move GC sweeping implementation to a new source file r=sfink

Rebased and re-landed.

Flags: needinfo?(jcoppeard)
No longer regressions: 1731127
You need to log in before you can comment on or make changes to this bug.