Closed Bug 1601298 Opened 1 year ago Closed 1 year ago

Initialize flex container and its helper classes' members in the declaration

Categories

(Core :: Layout: Flexbox, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(5 files)

We might need to tweak some members' initial value in the flex container or add new members in bug 1155772. Initializing members directly in the declaration can also avoid some duplicate if the class has more than one constructor like FlexItem.

In this way, we can avoid duplicates in FlexItem's normal constructor
and 'struct' constructor.

Attachment #9113495 - Attachment description: Bug 1601298 - Initialize nsFlexContainerFrame's memebers in the declaration. r=dholbert → Bug 1601298 - Initialize nsFlexContainerFrame's members in the declaration. r=dholbert
Attachment #9113493 - Attachment is obsolete: true
Attachment #9113493 - Attachment is obsolete: false
Attachment #9113491 - Attachment description: Bug 1601298 - Initialize FlexItem's members in the declaration. r=dholbert → Bug 1601298 - Initialize FlexItem's members in the declaration.
Attachment #9113492 - Attachment description: Bug 1601298 - Initialize FlexLine's members in the declaration. r=dholbert → Bug 1601298 - Initialize FlexLine's members in the declaration.
Attachment #9113494 - Attachment description: Bug 1601298 - Initialize PositionTracker and its derived classes' members in the declaration. r=dholbert → Bug 1601298 - Initialize PositionTracker and its derived classes' members in the declaration.
Attachment #9113495 - Attachment description: Bug 1601298 - Initialize nsFlexContainerFrame's members in the declaration. r=dholbert → Bug 1601298 - Initialize nsFlexContainerFrame's members in the declaration.
Attachment #9113493 - Attachment description: Bug 1601298 - Initialize FlexboxAxisTracker's members in the declaration. r=dholbert → Bug 1601298 - Initialize FlexboxAxisTracker's members in the declaration.
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3f070b6b84df
Initialize FlexItem's members in the declaration. r=mats
https://hg.mozilla.org/integration/autoland/rev/c387f75639de
Initialize FlexLine's members in the declaration. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/7d3276828f19
Initialize PositionTracker and its derived classes' members in the declaration. r=mats
https://hg.mozilla.org/integration/autoland/rev/81e6c6f4deef
Initialize nsFlexContainerFrame's members in the declaration. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/f30220bcafdc
Initialize FlexboxAxisTracker's members in the declaration. r=mats
You need to log in before you can comment on or make changes to this bug.