Closed Bug 1601377 Opened 6 years ago Closed 6 years ago

Change some nsContentUtils function signatures to take nsIPrincipal& to make it clear it can't be null

Categories

(Core :: DOM: Core & HTML, task)

Product:
Core
Component:
DOM: Core & HTML
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

Bug 1601377 part 1. Make it clear that nsContentUtils::PrincipalAllowsL10n never takes a null nsIPrincipal. r=smaug
47 bytes, text/x-phabricator-request
Details | Review
Bug 1601377 part 2. Make it clear that nsContentUtils::PrincipalHasPermission never takes a null nsIPrincipal. r=smaug
47 bytes, text/x-phabricator-request
Details | Review

Specifically:

  • nsContentUtils::PrincipalAllowsL10n
  • nsContentUtils::PrincipalHasPermission
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff0438c247fc part 1. Make it clear that nsContentUtils::PrincipalAllowsL10n never takes a null nsIPrincipal. r=smaug https://hg.mozilla.org/integration/autoland/rev/5412dc0ae670 part 2. Make it clear that nsContentUtils::PrincipalHasPermission never takes a null nsIPrincipal. r=smaug

https://hg.mozilla.org/mozilla-central/rev/ff0438c247fc
https://hg.mozilla.org/mozilla-central/rev/5412dc0ae670

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: