1601444 - Server timings not added on transaction close

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Sorin Davidoi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Disable cache and reload https://firefox-devtools-trailing-server-timing.glitch.me/ multiple times.

Actual results:

Most of the times the server timings are not shown in the timings panel.

Expected results:

The server timings should always be shown.

Comment 1

[Sorin Davidoi]

Attachment: fix(devtools/network-monitor): Always show server timings

Report server timings if they are sent when the transaction is closed.

Comment 2

[Sorin Davidoi]

I think this might be the cause of reports such as https://twitter.com/eMerzh/status/1201969919950303232 and https://twitter.com/anonimoconiglio/status/1202312124309147650.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't see server timings at all, see bug 1600912
Could this be a dup?

Comment 4

[Sorin Davidoi]

Yeah I guess it's a duplicated.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/395fa0c93653
fix(devtools/network-monitor): Always show server timings r=Honza

Comment 7

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Massively improves reliability for a DevTools feature we shipped in 71.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/395fa0c93653

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9113605 [details]
fix(devtools/network-monitor): Always show server timings

Beta/Release Uplift Approval Request

• User impact if declined: Developers can't see timings sent from the server (over HTTP headers)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only impacts developers, small patch.
• String changes made/needed:

Comment 10

[Julien Cristau [:jcristau]]

I can take an uplift, but I'm not sure this is bad enough to need tracking.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9113605 [details]
fix(devtools/network-monitor): Always show server timings

netmonitor fix for 72.0b5

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ca0daf7cd8d