Closed Bug 1601444 Opened 1 year ago Closed 1 year ago

Server timings not added on transaction close

Categories

(DevTools :: Netmonitor, defect, P2)

71 Branch
defect

Tracking

(firefox71 wontfix, firefox72- fixed, firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox71 --- wontfix
firefox72 - fixed
firefox73 --- fixed

People

(Reporter: mozilla-bugzilla, Assigned: mozilla-bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Disable cache and reload https://firefox-devtools-trailing-server-timing.glitch.me/ multiple times.

Actual results:

Most of the times the server timings are not shown in the timings panel.

Expected results:

The server timings should always be shown.

Report server timings if they are sent when the transaction is closed.

Assignee: nobody → sorin.davidoi

I can't see server timings at all, see bug 1600912
Could this be a dup?

Flags: needinfo?(sorin.davidoi)

Yeah I guess it's a duplicated.

Flags: needinfo?(sorin.davidoi)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/395fa0c93653
fix(devtools/network-monitor): Always show server timings r=Honza

[Tracking Requested - why for this release]: Massively improves reliability for a DevTools feature we shipped in 71.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73

Comment on attachment 9113605 [details]
fix(devtools/network-monitor): Always show server timings

Beta/Release Uplift Approval Request

  • User impact if declined: Developers can't see timings sent from the server (over HTTP headers)
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only impacts developers, small patch.
  • String changes made/needed:
Attachment #9113605 - Flags: approval-mozilla-beta?

I can take an uplift, but I'm not sure this is bad enough to need tracking.

Comment on attachment 9113605 [details]
fix(devtools/network-monitor): Always show server timings

netmonitor fix for 72.0b5

Attachment #9113605 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.