Open Bug 1601460 Opened 4 years ago Updated 1 year ago

ubuntu1804 - dom/html/test/browser_fullscreen-newtab.js | The chrome document should not be in fullscreen -

Categories

(Core :: DOM: Core & HTML, defect, P5)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
REOPENED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

Details

Attachments

(2 files)

Bug 1601460 - mark browser_fullscreen-newtab.js as expected failure on ubuntu1804
47 bytes, text/x-phabricator-request
Details | Review
Bug 1601460 - Fixed typo r=jmaher
47 bytes, text/x-phabricator-request
Details | Review

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279481428&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XioIBHFuQ3OQUQhW6C8fvA/runs/0/artifacts/public/logs/live_backing.log

suite: mochitest-browser-chrome
chunk: 5

context:
[task 2019-12-04T02:14:58.648Z] 02:14:58 INFO - TEST-START | dom/html/test/browser_fullscreen-newtab.js
[task 2019-12-04T02:14:59.072Z] 02:14:59 INFO - GECKO(10930) | JavaScript error: , line 0: TypeError: The expression cannot be converted to return the specified type.
[task 2019-12-04T02:14:59.176Z] 02:14:59 INFO - GECKO(10930) | JavaScript error: resource:///actors/DOMFullscreenParent.jsm, line 89: Error: TelemetryStopwatch: key "FULLSCREEN_CHANGE_MS" was already initialized
[task 2019-12-04T02:14:59.943Z] 02:14:59 INFO - GECKO(10930) | JavaScript error: , line 0: TypeError: The expression cannot be converted to return the specified type.
[task 2019-12-04T02:15:00.181Z] 02:15:00 INFO - TEST-INFO | started process screentopng
[task 2019-12-04T02:15:00.541Z] 02:15:00 INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-04T02:15:00.542Z] 02:15:00 INFO - Buffered messages logged at 02:14:58
[task 2019-12-04T02:15:00.542Z] 02:15:00 INFO - Entering test bound
[task 2019-12-04T02:15:00.542Z] 02:15:00 INFO - Buffered messages logged at 02:14:59
[task 2019-12-04T02:15:00.544Z] 02:15:00 INFO - Got fullscreenerror event
[task 2019-12-04T02:15:00.544Z] 02:15:00 INFO - Console message: [JavaScript Warning: "Request for fullscreen was denied because requesting element is not in the currently focused tab." {file: "resource:///actors/DOMFullscreenChild.jsm" line: 30}]
[task 2019-12-04T02:15:00.544Z] 02:15:00 INFO - Console message: [JavaScript Error: "TypeError: The expression cannot be converted to return the specified type."]
[task 2019-12-04T02:15:00.544Z] 02:15:00 INFO - Console message: [JavaScript Error: "Error: TelemetryStopwatch: key "FULLSCREEN_CHANGE_MS" was already initialized" {file: "resource:///actors/DOMFullscreenParent.jsm" line: 89}]
[task 2019-12-04T02:15:00.544Z] 02:15:00 INFO - TEST-PASS | dom/html/test/browser_fullscreen-newtab.js | The chrome window should not be in fullscreen -
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - TEST-PASS | dom/html/test/browser_fullscreen-newtab.js | The chrome document should not be in fullscreen -
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Leaving test bound
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Entering test bound
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Buffered messages logged at 02:15:00
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Got fullscreenerror event
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Console message: [JavaScript Warning: "Request for fullscreen was denied because requesting element is not in the currently focused tab." {file: "resource:///actors/DOMFullscreenChild.jsm" line: 30}]
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Console message: [JavaScript Error: "TypeError: The expression cannot be converted to return the specified type."]
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - TEST-PASS | dom/html/test/browser_fullscreen-newtab.js | The chrome window should not be in fullscreen -
[task 2019-12-04T02:15:00.556Z] 02:15:00 INFO - Buffered messages finished
[task 2019-12-04T02:15:00.557Z] 02:15:00 INFO - TEST-UNEXPECTED-FAIL | dom/html/test/browser_fullscreen-newtab.js | The chrome document should not be in fullscreen -
[task 2019-12-04T02:15:00.557Z] 02:15:00 INFO - Stack trace:
[task 2019-12-04T02:15:00.557Z] 02:15:00 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2019-12-04T02:15:00.557Z] 02:15:00 INFO - chrome://mochitests/content/browser/dom/html/test/browser_fullscreen-newtab.js:runTest/<:73
[task 2019-12-04T02:15:00.557Z] 02:15:00 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:152
[task 2019-12-04T02:15:00.557Z] 02:15:00 INFO - chrome://mochitests/content/browser/dom/html/test/browser_fullscreen-newtab.js:runTest:17
[task 2019-12-04T02:15:00.558Z] 02:15:00 INFO - chrome://mochitests/content/browser/dom/html/test/browser_fullscreen-newtab.js:null:96
[task 2019-12-04T02:15:00.558Z] 02:15:00 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-12-04T02:15:00.558Z] 02:15:00 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-12-04T02:15:00.558Z] 02:15:00 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - GECKO(10930) | JavaScript error: resource:///actors/DOMFullscreenParent.jsm, line 89: Error: TelemetryStopwatch: key "FULLSCREEN_CHANGE_MS" was already initialized
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - Leaving test bound
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - Console message: [JavaScript Warning: "Exited fullscreen because fullscreen element was removed from document." {file: "chrome://browser/content/tabbrowser.js" line: 3600}]
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - Console message: [JavaScript Error: "Error: TelemetryStopwatch: key "FULLSCREEN_CHANGE_MS" was already initialized" {file: "resource:///actors/DOMFullscreenParent.jsm" line: 89}]
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - GECKO(10930) | MEMORY STAT | vsize 3174MB | residentFast 378MB | heapAllocated 168MB
[task 2019-12-04T02:15:00.561Z] 02:15:00 INFO - TEST-OK | dom/html/test/browser_fullscreen-newtab.js | took 1581ms

:xidorn - in searchfox I saw that you worked on this file back in 2018. I am seeing this test fail consistently on the ubuntu1804 environment, with a black screen as the screenshot. Could you take a look, or if not appropriate, please pass on the ni to someone who may be able to take a look and comment?

The ubuntu1804 test image can be used on tryserver by using ./mach try fuzzy --ubuntu-bionic, then selecting the linux64 jobs as normal.

Flags: needinfo?(xidorn+moz)

After some investigation, this test passed with compiz installed in the ubuntu1804 test image. However, since compiz is not installed by default on ubuntu1804 and wanting to ensure that we test in the closest possible environment for end users, this bug still needs attention.

Knowing that having only the window manager (which removes the top bar, dock, and other elements of a full desktop environment) should help with the fixing of this test. The expected migration date to ubuntu1804 is end of December, so I am hoping to either have a fix or disable this test by that date.

This may be resolved by the changes in Bug 1602701, but if it does not I am proposing to mark this test with a fail-if annotation specific to ubuntu1804.

Assignee: nobody → egao
Status: NEW → ASSIGNED
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17db8bb7bbeb
mark browser_fullscreen-newtab.js as expected failure on ubuntu1804 r=jmaher

https://hg.mozilla.org/mozilla-central/rev/17db8bb7bbeb

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Disabling a test shouldn't be considered to be a fix of the test issue I suppose.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

You're right, the bug should have been marked with a leave-open, but since only a few handful of bugs are now blocking the migration of mochitest-browser-chrome to ubuntu1804, I made the decision to mark it with a fail-if.

If the test begins passing again in the future we will know since I didn't disable it with a skip-if.

Verified https://searchfox.org/mozilla-central/source/dom/html/test/browser.ini#32 and https://hg.mozilla.org/mozilla-central/rev/17db8bb7bbeb#l1.12 and noticed that is missing "f" from fail-if command.

Joel, can we update the patch?

Flags: needinfo?(jmaher)

:ccoroiu, that should be fixed, could you fix that?

Flags: needinfo?(jmaher) → needinfo?(ccoroiu)
Flags: needinfo?(ccoroiu)

This test is now skipped on linux1804 platform, and should be worked on to re-enable on the platform as soon as possible.

Assignee: egao → nobody
Assignee: nobody → dluca
Severity: normal → S3
Severity: normal → S3

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: dluca → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: