1601486 - Motion path is not correct for <g> SVG elements with transform-box:fill-box

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect, P3)

Description

[Boris Chiou [:boris]]

Attachment: test case

It seems nsFrame::GetPosition() doesn't work as I expected for <g> SVG element in this case. I thought it will return the values of cx and cy in app units, so perhaps we have to use nsLayoutUtils::ComputeGeometryBox(aFrame, StyleGeometryBox::FillBox) to get the correct position of the svg element.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1601486 - Use bbox for calculating the alignment for motion path transformation on eSVGContainer elements (e.g. <g>).

When we apply the transformation on the <g> element, its transformation also
performs on its child elements. So Motion-path should also work well in this
case.

For offset-path:path(), we have to make sure the element is on the svg path, no
matter what is its x and y values. That's why we have to calculate the
the frame position of the transformed SVG element if transform-box is fill-box.
However, for <g> element, its nsIFrame::GetPosition() is (0, 0), so we have to
calculate the geometry bbox instead, to make sure it works well on <g> or other
svg transformed elements.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4cce6206c25
Use bbox for calculating the alignment for motion path transformation on eSVGContainer elements (e.g. <g>). r=longsonr

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20687 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e4cce6206c25

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot