Open Bug 1601501 Opened 6 years ago Updated 3 years ago

Categories

(Core :: Layout: Text and Fonts, defect, P5)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279654924&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Ed2AnA4OTyWawTv_8m85hg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Ed2AnA4OTyWawTv_8m85hg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


suite: web-platform-test-reftest
chunk: 3

context:
[task 2019-12-04T22:34:16.599Z] 22:34:16 INFO - TEST-START | /css/css-text-decor/line-through-vertical.html
[task 2019-12-04T22:34:16.620Z] 22:34:16 INFO - Setting pref layout.css.text-decoration-thickness.enabled (true)
[task 2019-12-04T22:34:16.829Z] 22:34:16 INFO - PID 19806 | 1575498856826 Marionette INFO Testing http://web-platform.test:8000/css/css-text-decor/line-through-vertical.html == http://web-platform.test:8000/css/css-text-decor/reference/line-through-vertical-ref.html
[task 2019-12-04T22:34:17.092Z] 22:34:17 INFO - PID 19806 | 1575498857086 Marionette INFO No differences allowed
[task 2019-12-04T22:34:17.144Z] 22:34:17 INFO - TEST-UNEXPECTED-FAIL | /css/css-text-decor/line-through-vertical.html | Testing http://web-platform.test:8000/css/css-text-decor/line-through-vertical.html == http://web-platform.test:8000/css/css-text-decor/reference/line-through-vertical-ref.html
[task 2019-12-04T22:34:17.144Z] 22:34:17 INFO - Found 4134 pixels different, maximum difference per channel 255

This is a strange failure, since there appears to be no manifest indicating that this test should pass on all platforms, but on ubuntu1804 it seems to fail inexplicably.

I loaded up the file in a VM, and was indeed able to reproduce the difference. See attached screenshot - leftmost is FF73 on macosx1015, middle is ubuntu1804 on whatever FF ships by default with, and right hand side is the reftest analyzer.

Jonathan, I know I have pinged you in other bugs, thanks for responding to my needinfos there. This one is quite strange, do you think this is related to the text rendering difference in bug 1600777 (gujarati-3b)?

Flags: needinfo?(jfkthame)

It looks like the problem here is that the line-through-vertical.html testcase uses lang="ja" on one of its <span>s, which will cause it to use the Japanese font preferences, which won't match the Latin prefs used for lang="en" in the reference file.

The testcase tries to overcome this by explicitly setting font-family: Times, so that a consistent font will be used everywhere, but that doesn't work if there's no font called Times on the system. On macOS, Times is present by default; on Windows, there's a substitution rule that uses Times New Roman instead; but on Linux, it'll depend how fontconfig is set up. I guess our existing configuration probably has a fontconfig alias that recognizes the family name "Times" and substitutes Nimbus Roman or something like that, but on the ubuntu1804 there's no such rule, and so we end up hitting the Japanese font prefs for the lang="ja" element.

So I think this is basically a flaw in the test; it's making unjustified assumptions about the environment. We could probably resolve it by some kind of adjustment to the fontconfig setup, adding a configuration fragment that provides a substitute for "Times".

Flags: needinfo?(jfkthame)

I attempted to see if installing the times font on my local ubuntu1804 VM would help, but it seems macosx1015 and virtualbox don't play too well together, often causing a kernel panic on the host macosx1015.

For the record, I was able to successfully install ttf-mscorefonts-installer. Without rebooting, I loaded up the test in the browser and the issue remains, but since rebooting the VM causes a kernel panic on my mac I am not able to verify after a reboot of the guest ubuntu1804.

Firefox version is 70.0.1 on the ubuntu1804 VM.

With the timeframe for migration to ubuntu1804 approaching quickly, I'd like to propose to mark this test as an expected failure on ubuntu1804 while a fix is investigated.

:jfkthame - would the course of action above be acceptable? Are there any other investigative items that you would like me to investigate?

Flags: needinfo?(jfkthame)
Assignee: nobody → egao
Status: NEW → ASSIGNED
Pushed by egao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ec4a0537ba4 mark line-through-vertical.html as expected failure on ubuntu1804 r=jmaher

This test has been marked as expected failure for linux1804.

If it is important to have the test run and report proper results, please assign someone to investigate the root cause.

Assignee: egao → nobody
Status: ASSIGNED → NEW
Keywords: leave-open
Severity: normal → S3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: