Closed
Bug 1601604
Opened 5 years ago
Closed 5 years ago
Don't emit unnecessary jump target when the loop has no 'continues'
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
This should be easy to do now.
|
Assignee | |
Comment 1•5 years ago
|
||
I had to fix the Script-getAllColumnOffsets.js test: because we no longer emit
the jump target when there are no continues in the loop, the flow graph code
no longer reached the loop condition when the body has an unconditional break.
|
||
Updated•5 years ago
|
Attachment #9113775 -
Attachment description: Bug 1601604 - Cleanup 'continue' handling in the emitter and don't emit a jump target when thare are no continues. r?arai!,loganfsmyth! → Bug 1601604 - Clean up 'continue' handling in the emitter and don't emit a jump target when thare are no continues. r?arai!,loganfsmyth!
|
||
Updated•5 years ago
|
Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7af07274dcad
Clean up 'continue' handling in the emitter and don't emit a jump target when thare are no continues. r=arai,loganfsmyth
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•