1601616 - push SETA optimized when it shall have full task set instead

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Take a look at this recent autoland history in which 51a55dd05602 should have all tasks but got SETA optimized:

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Cretry%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel&tochange=f33a1ee1f74a8a6a737b0dad7bfd23725e2482d4&fromchange=ba237def08d57263dda0232d34526ee3b3b265ca&searchStr=windows7%2Cship

03:54:11 UTC push got full task set
(04:28:10 tasks had been requested later at ~13:00)
06:10:33 push 51a55dd05602 is the first one more than 2 hours after the previous one with the full task set and should schedule all tasks according to rules implemented in bug 1581194; it touches the dom/, network/ and toolkit/ folders of the build and therefore no in-tree rules to drop common build and test tasks based on files changed should apply.
08:57:31 full task set schedule for push f33a1ee1f74a which is the tenth push after the one from 03:54:11

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

it seems that the time window is between current and previous push:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/optimize/seta.py#170

not the time window between current and last full seta push.

I think a way to fix this is to continue to check against the last push, if that is < 120 continue on and find the previous Nth push ID and compare that timestamp.

That won't be perfect, but it would help.

Comment 2

[Andrew Halberstadt [:ahal]]

In the meantime we could bump the time window back down to 1 hour if it helps.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1601616 - Schedule full set of tasks for autoland push after 1 hour without push instead of 2. r=ahal

Makes it more likely that the full task set will be scheduled in off-peak hours,
required to use the push as merge candidate for merges to mozilla-central.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a65475ccaa4
Schedule full set of tasks for autoland push after 1 hour without push instead of 2. r=ahal

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0a65475ccaa4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:aryx, maybe it's time to close this bug?

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

We are using a 'every 2h or every 20th push, what applies first' strategy these days and it is usable for sheriffing.