1601630 - Remove WebConsoleUI evaluateJSAsync

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This function (devtools/client/webconsole/webconsole-ui.js#497-504 ) directly calls the main target WebConsoleFront evaluateJSAsync method, which means it does not benefit from the work we did in the commands evaluateJSAsync to retrieve the correct webConsoleFront to talk to.

There are only a couple of consumers:

• inspector's "Use in console" context menu entry
• a console mochitest

so it should be easy to migrate, and call the command method instead.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1601630 - Remove WebConsoleUI evaluateJSAsync. r=jlast.

This method was directly using the main target console front
to evaluate something, which could cause issue in a fission
world.
The function is removed, and callsites now call the command
evaluateJSAsync, in which we retrieve the appropriate front
given the given options object (e.g. if there's a selecteObjectActor,
we'll talk to the target that hold the actor).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/deda1cad1f65
Remove WebConsoleUI evaluateJSAsync. r=jlast.

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/deda1cad1f65