Closed Bug 1601650 Opened 4 years ago Closed 4 years ago

Cannot double click on MUC participants to open private conversations

Categories

(Chat Core :: XMPP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: clokep, Unassigned)

Details

(Keywords: regression)

It seems it is no longer possible to double click on a participant in an XMPP MUC and open a conversation to that person. When I do it I get another tab that shares the name of the MUC. I'm unsure what the "destination" this is if I were to send a message. When doing some testing, it seems like the destination is correct and it is just the name of the conversation that is wrong.

STR:

  1. Open an XMPP MUC (e.g. foo@bar.baz).
  2. Double click on a participant.
  3. See that a new private conversation opens, but the name is foo@bar.baz.

I tried to find when this broke, but I tested all the way back to TB 52 and it seemed to have this error, so I'm not sure it ever worked for Thunderbird?

Hey Florian, any idea of where to start looking to debug this? I poked around a bit but haven't been able to pinpoint the location where this double click handler exists?

Flags: needinfo?(florian)

(In reply to Patrick Cloke [:clokep] from comment #2)

I poked around a bit but haven't been able to pinpoint the location where this double click handler exists?

https://searchfox.org/comm-central/rev/065eb16ca361300b4b116f6c69ebd10ea1e6c1d0/mail/components/im/content/chat-messenger.js#990

Flags: needinfo?(florian)

I think this is defined in https://xmpp.org/extensions/xep-0045.html#privatemessage, so it actually seems like our code might be "OK", but we definitely used to open the "proper" conversation for this at some point.

This works fine, I got really confused about the different types of JIDs (between a full JID and a JID that's via chat). Sorry for the noise.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.