160168 - option+click link to download link target is broken

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2002.07.30.05 nb. option+click link to download link target doesn't
work. (however, option+return a link does work to download a link.)

i thought this used to work, but lemme see if it regressed...

Comment 1

[sairuh (rarely reading bugmail)]

looks like this broke btwn 7/25 (fine) and 7/29 (broken). will narrow down some
more...

Comment 2

[sairuh (rarely reading bugmail)]

more narrowing: this is fine with the 2002.07.26.05 nb, but broken in the
2002.07.27.05 nb.

Comment 3

[saari (gone)]

->ccarlen, just a guess. Any better candidates?

Comment 4

[Conrad Carlen (not reading bugmail)]

Simon, my guess is that this happened due to some higher-level changes to
downloading rather than uriloader or file stuff.

Comment 5

[Simon Fraser [no longer active]]

I'll take a look

Comment 6

[Winnie Lam]

Not sure if keyboard shortcut changes have something to do with this.  I noticed
that the keyboard shortcuts for Back and Forward were changed since the 07-30
build from cmd-leftarrow/cmd-rightarrow to cmd-[/cmd-].

Comment 7

[Simon Fraser [no longer active]]

It's throwing an exception calling [NSString fileSystemRepresentation] on an
empty string.

Comment 8

[Simon Fraser [no longer active]]

Fixed.

Comment 9

[Simon Fraser [no longer active]]

Really fixed.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.08.09.05 chimera bits.