1601688 - If an event is only needed in tests, only emit it when in test

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

we saw in the past that emitting events could add some overhead, so let's try to not emit them when it's not needed

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1601688 - Don't rely on new-messages event in webconsole DAMP tests. r=ochameau.

The tests are now using mutation observer to check
when the dom is updated instead.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1601688 - Use emitForTests when events are only used in tests. r=Honza.

Depends on D57499

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aa05612f10f
Don't rely on new-messages event in webconsole DAMP tests. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/27cec4c76272
Use emitForTests when events are only used in tests. r=Honza.

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1601688) for causing node-devtools failures.

Backout revision https://hg.mozilla.org/integration/autoland/rev/40f3654a935a8d60a0faa1faa5e29440a054dd8b

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=284203983&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-devtools-tests%2Cnode%28devtools%29&revision=27cec4c762725e102fe86f77f736d7052a7fe1f7

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=284203983&repo=autoland

Nicolas can you please take a look?

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Sorry about that, I'll provide a fix in the next minutes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f6d5888aa5d
Don't rely on new-messages event in webconsole DAMP tests. r=ochameau.

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1f6d5888aa5d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3438f1628cb7
Use emitForTests when events are only used in tests. r=Honza.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3438f1628cb7