1601701 - Bump mingw-w64 and add -lssp support

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

For several bugs we need to update mingw-w64 library. To perform that update we will need to either disable FORTIFY_SOURCE support or add in -lssp; let's just bump and add ssp support at once.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1601701 - Add -lssp to the mingw-clang for FORTIFY_SOURCE support r?#Build

Comment 2

[(Away)]

For posterity can you elaborate on what specific code needs ssp?

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Unlike glibc, mingw-w64 does not provide fortified functions at all. (I'm unsure why.) Fortification requires -lssp (or -fstack-protector which adds -lssp implicitly) to work. libssp is a part of gcc libraries, so we need to go grab it out of gcc sources and build it separately.

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1601701 - Build libssp as part of the mingw-clang toolchain build r?#Build

llvm-mingw has found a way to build libssp indepdendent of gcc which
is great. We set up some stuff to support that and then use that method.

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1601701 - Bump the mingw-w64 revision r?#Build

Depends on D56000

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5055c0077a0d
Add -lssp to the mingw-clang for FORTIFY_SOURCE support r=dmajor
https://hg.mozilla.org/integration/autoland/rev/837d44320e3b
Bump the mingw-w64 revision r=dmajor
https://hg.mozilla.org/integration/autoland/rev/4e78e9e5a426
Build libssp as part of the mingw-clang toolchain build r=froydnj

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5055c0077a0d
https://hg.mozilla.org/mozilla-central/rev/837d44320e3b
https://hg.mozilla.org/mozilla-central/rev/4e78e9e5a426

Comment 8

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1601701 - Build libssp as part of the mingw-clang toolchain build, bump mingw, add -lssp (esr68)

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
Build improvements to the mingw-clang build to reach parity with Tor Browser's current build

User impact if declined: The mingw-clang build on esr68 won't match Tor's. (They use -lssp and fortify source and stack protector)

Fix Landed on Version: Nightly 12/09

Risk to taking this patch (and alternatives if risky): The mingw-clang build might break.

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9114957 [details] [diff] [review]
Bug 1601701 - Build libssp as part of the mingw-clang toolchain build, bump mingw, add -lssp (esr68)

mingw build change for Tor browser parity. NPOTB for mainline Firefox ESR. Approved for 68.4esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/c677377208c2