1601734 - Rename AbstractScope to AbstractScopePtr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

AbstractScope (to be landed in Bug 1592102) is perhaps better referred to as AbstractScopePtr because of how it's used.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Prerequisites

Before getting started, you'll want to

• You Have a checkout of the Firefox source code
• Make sure you can build SpiderMonkey
• Understand the basics of using Mercurial
• Understand how to submit a patch
• Read this walkthrough about how development works in Firefox

Success Criteria

• The type AbstractScope has been renamed to AbstractScopePtr.
• After this rename, the engine compiles, and passes the tests (run ../jit-test/jit_test.py ./dist/bin/js from your build directory)

Questions

If you have questions, feel free to visit us on in the Spidermonkey room on Matrix, or post questions here.

Comment 2

[Kousuke Takaki]

Attachment: Bug 1601734 - Rename AbstractScope to AbstractScopePtr r=mgaudet

Comment 3

[Kousuke Takaki]

Attachment: Bug 1601734 - Rename AbstractScope to AbstractScopePtr r=mgaudet

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5af318a2b56
Rename AbstractScope to AbstractScopePtr r=mgaudet

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f5af318a2b56