Closed
Bug 1601781
Opened 4 years ago
Closed 4 years ago
Forward declare ContentParent in BrowsingContextGroup.h so it doesn't pull in the world
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
2.36 KB,
patch
|
Details | Diff | Splinter Review |
I've suddenly got breakage in a patch set because DOM bindings are pulling in BrowsingContextGroup.h, which is pulling in ContentParent.h, which is pulling in everything that entails.
Looks like we can just forward declare ContentParent, which eliminates the problem.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3bd59939150 Forward declare ContentParent in BrowsingContextGroup; r=kmag
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfa71e81e863 Backed out changeset d3bd59939150 for build bustages at BrowsingContextGroup.h. CLOSED TREE https://hg.mozilla.org/integration/autoland/rev/f6346b33438c Forward declare ContentParent in BrowsingContextGroup; r=kmag CLOSED TREE
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
|
||
Updated•4 years ago
|
Blocks: includehell
You need to log in
before you can comment on or make changes to this bug.
Description
•