1601786 - Remove the "allow on any site" option from the storage access API prompt

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[(no longer active)]

The "allow on any site" option on the storage access API prompt has consistently seen extremely low usage. For example, on Beta 70, the prompt was displayed ~253,000 times. only four sessions show the user selecting "allow on any site" (https://mzl.la/2OWYH5P).

I propose removing this option in order to simplify our prompt, the associated code behind it as well as the associated telemetry a bit.

Comment 1

[(no longer active)]

Attachment: Bug 1601786 - Remove the "allow on any site" option from the storage access API prompt;

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7842b0d5e8a
Remove the "allow on any site" option from the storage access API prompt; r=baku

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset c7842b0d5e8a (bug 1601786) for failing at browser_PermissionUI_prompts.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/29aab0149c69ef6f7c325210bede9bf6d0b13775

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=281785488&resultStatus=testfailed%2Cbusted%2Cexception&revision=c7842b0d5e8a0d24734b48659808efc36e90a7be

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281785488&repo=autoland&lineNumber=17625

Log snippet:

task 2019-12-18T20:03:10.931Z] 20:03:10 INFO - Leaving test bound test_midi_permission_prompt
[task 2019-12-18T20:03:10.932Z] 20:03:10 INFO - Entering test bound test_storage_access_permission_prompt
[task 2019-12-18T20:03:10.933Z] 20:03:10 INFO - Buffered messages logged at 20:03:10
[task 2019-12-18T20:03:10.933Z] 20:03:10 INFO - TEST-PASS | browser/modules/test/browser/browser_PermissionUI_prompts.js | Should have gotten the notification - [object Object] == true -
[task 2019-12-18T20:03:10.934Z] 20:03:10 INFO - TEST-PASS | browser/modules/test/browser/browser_PermissionUI_prompts.js | Should be showing a <xul:popupnotification> - 1 == 1 -
[task 2019-12-18T20:03:10.934Z] 20:03:10 INFO - Buffered messages finished
[task 2019-12-18T20:03:10.935Z] 20:03:10 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_PermissionUI_prompts.js | There should only be 2 secondary action(s) - 1 == 2 - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_PermissionUI_prompts.js :: testPrompt/< :: line 122
[task 2019-12-18T20:03:10.935Z] 20:03:10 INFO - Stack trace:
[task 2019-12-18T20:03:10.936Z] 20:03:10 INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_PermissionUI_prompts.js:testPrompt/<:122
[task 2019-12-18T20:03:10.936Z] 20:03:10 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:150
[task 2019-12-18T20:03:10.937Z] 20:03:10 INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_PermissionUI_prompts.js:testPrompt:61
[task 2019-12-18T20:03:10.937Z] 20:03:10 INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_PermissionUI_prompts.js:test_storage_access_permission_prompt:56
[task 2019-12-18T20:03:10.938Z] 20:03:10 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2019-12-18T20:03:10.938Z] 20:03:10 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2019-12-18T20:03:10.938Z] 20:03:10 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2019-12-18T20:03:10.939Z] 20:03:10 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2019-12-18T20:03:10.939Z] 20:03:10 INFO - TEST-PASS | browser/modules/test/browser/browser_PermissionUI_prompts.js | Should be showing a <xul:popupnotification> - 1 == 1 -
[task 2019-12-18T20:03:10.940Z] 20:03:10 INFO - TEST-PASS | browser/modules/test/browser/browser_PermissionUI_prompts.js | Should be showing a <xul:popupnotification> - 1 == 1 -
[task 2019-12-18T20:03:10.941Z] 20:03:10 INFO - Not taking screenshot here: see the one that was previously logged

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6491bf7a2649
Remove the "allow on any site" option from the storage access API prompt; r=baku

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/6491bf7a2649