1601795 - Ctrl+I shortcut key for Page Info opens the bookmarks sidebar instead

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[schneemannbruzzler]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Pressed ctrl+i (German version)

Actual results:

instead bookmarks are opened (actual hotkey for that: ctrl+b, does the same)

Expected results:

open site information in a pop-up

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Dão Gottwald [:dao]]

The key is duplicated here:
https://dxr.mozilla.org/l10n-central/rev/be41ad732148afb6a8a7d9c1023b32cd480c63f7/de/browser/chrome/browser/browser.dtd#105
https://dxr.mozilla.org/l10n-central/rev/be41ad732148afb6a8a7d9c1023b32cd480c63f7/de/browser/chrome/browser/browser.dtd#323

Where do we track locale-specific bugs?

Comment 3

[Dão Gottwald [:dao]]

Though it looks like en-US may be affected as well: https://searchfox.org/mozilla-central/rev/a92ed79b0bc746159fc31af1586adbfa9e45e264/browser/locales/en-US/chrome/browser/browser.dtd#165

Comment 4

[Francesco Lodolo [:flod]]

Localization issues for specific locales go into Mozilla Localizations::Language XXX

Having said that, I have checks that look out for keyboard shortcut deviations from en-US (there are few cases where it makes sense), and this problem originates in the en-US source.
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/browser.dtd:pageInfoCmd.commandkey&repo=gecko_strings
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/browser.dtd:bookmarksWinCmd.commandkey&repo=gecko_strings

Comment 5

[Dão Gottwald [:dao]]

There's an old wontfix on this issue: bug 215755. Edge based on Chromium doesn't support this shortcut so we should reconsider.

Even if we want to keep this shortcut for the bookmarks sidebar, we should stop duplicating it which is wrong no matter what. Turns out we completely disable the Page Info shortcut on Windows so technically there's no duplication: https://searchfox.org/mozilla-central/rev/be7d1f2d52dd9474ca2df145190a817614c924e4/browser/base/content/browser-sets.inc#236

Comment 6

[Marco Bonardo [:mak]]

Yes, we should reconsider, but first we must ensure the new Edge is the most common Microsoft Browser around (or at least more commonly used), because the old Edge is still using the CTRL+I shortcut for bookmarks.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [:mak] from comment #6)

Yes, we should reconsider, but first we must ensure the new Edge is the most common Microsoft Browser around (or at least more commonly used), because the old Edge is still using the CTRL+I shortcut for bookmarks.

This assumes that consistency with the most common Microsoft browser is of critical importance which I don't think reflects reality if even Microsoft doesn't think so for the new Edge. The most popular browser has been Chrome for some time now and Edge never became particularly popular in the first place.

Comment 8

[Marco Bonardo [:mak]]

It matters to us mostly to provide a simpler users migration experience on Windows. You have a fair point there with the fact MS itself doesn't seem to care, but it's also true the new Edge doesn't have a sidebar.
OT: I'm not sure how much QA Microsoft put on keyboard shortcuts, the shortcut they picked for managing bookmarks (ctrl+shift+O) is handled by Radeon Graphics drivers (I actually think AMD made a huge mistake with these default global shortcuts)...

Anyway, I was suggesting to wait for the old Edge updates to the new version, but I missed that MS already started a staged update for it!
Thus, I agree with you we can ignore the old Edge behavior and put back CTRL+I to open the Page Info on Windows too, and remove bookmarksWinCmd.commandkey

Comment 9

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [:mak] from comment #8)

It matters to us mostly to provide a simpler users migration experience on Windows.

But most Windows users don't use Edge in the first place. They use Chrome.

Anyway, I prepared a patch for this in the meantime... https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca42a1ab8779aea1c80b3434c9f3d586b1c8dd38

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1601795 - Let Ctrl+I open Page Info instead of the bookmarks sidebar on Windows. r=mak

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c5e64eb2b4
Let Ctrl+I open Page Info instead of the bookmarks sidebar on Windows. r=mak

Comment 12

[Dão Gottwald [:dao]]

We'll need to update https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly and possibly other help documents. I'd add the user-doc-needed keyword but it seems to have been disabled...

We might want to relnote this as well.

Release Note Request (optional, but appreciated)
[Why is this notable]: might break some users' habits
[Affects Firefox for Android]: no
[Suggested wording]: On Windows, Ctrl+I can now be used to open the Page Info window instead of opening the Bookmarks sidebar. Ctrl+B still opens the Bookmarks sidebar.
[Links (documentation, blog post, etc)]:

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/61c5e64eb2b4

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

Note added to 74 Nightly release notes.

Comment 15

[Joni Chan]

I've updated https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly/ to include Ctrl + I opening page info for Windows.