Open
Bug 1601812
Opened 4 years ago
Updated 4 years ago
Replace writing window.inner{Width,Height} with something others
Categories
(SeaMonkey :: Preferences, task)
SeaMonkey
Preferences
Tracking
(Not tracked)
NEW
People
(Reporter: hiro, Assigned: hiro, NeedInfo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.67 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1601811. We should use window.resizeTo() or resizeBy() instead of changing window.inner{Width,Height}.
|
Assignee | |
Comment 1•4 years ago
|
||
Assignee: nobody → hikezoe.birchill
|
|
Assignee | |
Updated•4 years ago
|
Attachment #9113998 -
Flags: review?(iann_bugzilla)
Comment on attachment 9113998 [details] [diff] [review] Use window.resizeBy() or resizeTo() instead of changing window.inner{Width,Height} LGTM r=me
Attachment #9113998 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•4 years ago
|
||
Ian, could you please land the patch? We have a bug report (bug 1639086) which is probably related to bug 1598487 depending on this change.
Flags: needinfo?(iann_bugzilla)
Will https://searchfox.org/comm-central/source/suite/components/shell/content/setDesktopBackground.js#26-27 also need fixing?
Flags: needinfo?(iann_bugzilla) → needinfo?(hikezoe.birchill)
|
|
Assignee | |
Comment 5•4 years ago
|
||
Oh yes, I missed the part. Would you mind replacing it with resizeBy()?
You need to log in
before you can comment on or make changes to this bug.
Description
•