1601827 - UpdatePing ready telemetry not being sent for staged updates

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

This was brought to my attention by tdsmith. This wasn't caught since there was only a test for the download without staging and not for the download with staging.

Note: it would be nice to rename these notifications which were added for the UI. Previously, an update-staged notification was sent and then a update-downloaded notification was sent so the UI was shown in case staging failed. It would be clearer to use the same notification topic with a generic name such as update-ready for both of these since we don't want to send an update-downloaded notification when staging is enabled since we don't want to show UI until the update is ready.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1601827 - Fix the UpdatePing 'ready' telemetry ping for staged updates. r=mhowell

Changes UpdatePing.jsm so it observes 'update-staged' notifications and adds a test so this shouldn't break in the future

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d67b8549cb5e
Fix the UpdatePing 'ready' telemetry ping for staged updates. r=mhowell

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d67b8549cb5e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we want to uplift to Beta?

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 9114077 [details]
Bug 1601827 - Fix the UpdatePing 'ready' telemetry ping for staged updates. r=mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Update 'ready' telemetry won't be available
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is simple, there are automated tests, and this patch has baked on nightly. I've also checked telemetry to verify that the telemetry is being reported on nightly.
• String changes made/needed: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9114077 [details]
Bug 1601827 - Fix the UpdatePing 'ready' telemetry ping for staged updates. r=mhowell

fix for update telemetry, approved for 72.0b10

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1f7cade7bd19