1601831 - Timer on google.com is rendered incorrectly

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[oleksandr.vlasiuk]

Attachment: firefox_vs_qutebrowser.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

• Open google.com in Firefox.
• Search for "timer". The first result is a frame with timer that has a button to go full screen.
• Press the full screen button.

Actual results:

The timer is rendered incorrectly, see the attached screenshot. This does not occur in the QtWebEngine-based qutebrowser.

Expected results:

The timer should be rendered correctly, as it is in qutebrowser.

Comment 1

[Peter Magyari (Desktop QA)]

Hello,

I'm unable to reproduce the issue, since I cannot find the "timer" frame you are talking about.
The first link I get from searching "timer" on google is https://www.timeanddate.com/timer/

Can you add the link you get as first result?

Also, could you check how it appears on Chrome ?

Thanks !

Comment 2

[oleksandr.vlasiuk]

Attachment: timer_frame.html

Source of the timer frame

Comment 3

[oleksandr.vlasiuk]

Hi Peter,
It is one of the built-in answers google provides, so the link is literally https://www.google.com/search?client=firefox-b-1-d&q=timer
I have attached the source of this frame, as well as the screenshot of what it looks like for me.

Chrome, Chromium, etc. all show the timer as the right half of the screenshot firefox_vs_qutebrowser.png attached previously. qutebrowser is also Blink-based, so this appears to be a Gecko vs Blink issue.

Comment 4

[oleksandr.vlasiuk]

Attachment: frame_screenshot.png

Comment 5

[oleksandr.vlasiuk]

Let me know if I can provide any further information!
Thanks,
-ov

Comment 6

[Peter Magyari (Desktop QA)]

The built-in timer does not appear for me on Firefox so I cannot confirm the issue, however, I'm going to set a component in order to involve the development team in reviewing it.

Thanks!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

They're using :-webkit-full-screen in their stylesheets instead of the standard :fullscreen, so Gecko doesn't understand it.

Ugh, Google. Mike, any chance to contact them? Have we seen a lot of problems with :fullscreen vs. :-webkit-full-screen? We could add an alias if we needed to.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Oh this is a bit worse even. They end up with :full-screen rules rather than :-webkit-full-screen in Firefox. That's still invalid of course.

Comment 9

[Mike Taylor [:miketaylr]]

Yep, sending them an email now.

Comment 10

[Mike Taylor [:miketaylr]]

Have we seen a lot of problems with :fullscreen vs. :-webkit-full-screen? We could add an alias if we needed to.

I don't think we have that many on file, but it seems like the aliasing ship has sailed.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1601831 - Accept :full-screen as an alias of :fullscreen. r=#style

Potential fix if Google doesn't fix it on their side.

I don't plan to land this for a couple weeks at least. Not sure if we want to
land this, but lacking Google fixing stuff this might be reasonable...

Comment 12

[Emilio Cobos Álvarez (:emilio)]

I'm not sure how I feel about this, I'd certainly rather not... But we could do this if needed, wdyt Mike?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Xidorn suggested a web-compat add-on intervention if needed, and I agree that's better.

Comment 14

[dtapuska]

146155668 is Google's internal tracking issue for that bug that was reported last month. It didn't get triaged. I'll try to find an owner.

Comment 15

[Mike Taylor [:miketaylr]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #13)

Xidorn suggested a web-compat add-on intervention if needed, and I agree that's better.

Agreed.

(In reply to dtapuska from comment #14)

146155668 is Google's internal tracking issue for that bug that was reported last month. It didn't get triaged. I'll try to find an owner.

Thanks Dave.

Ksenia, can we write an intervention for this? I wouldn't consider it a release-driver, but it's simple enough to fix on our end until Google fixes it.

Comment 16

[Ksenia Berezina [:ksenia]]

Yeah, added a bug for that

Comment 17

[Ksenia Berezina [:ksenia]]

Attachment: Screen Shot 2020-01-17 at 10.40.21 AM.png

Looks like this has been fixed by google

Comment 18

[dtapuska]

Yup. we weren't certain 100% when rollout would happen but it looks like it happened today as expected.