1601858 - Cannot cancel Decision Tasks or provide better error message explaining decision tasks cannot be cancelled

Status: NEW

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Tom Ritter [:tjr]]

Sometimes I accidentally submit a try job and realize I made an error immediately. I'd like to cancel it ASAP, but I am unable to cancel a decision task.

Choosing cancel all jobs gives me an error like Error getting Gecko Decision Tasks for ids: 607155: 404: No decision tasks found for pushes: ['607155']

Choosing to cancel the Decision task specifically give me an error Unable to cancel job

Comment 1

[Mike Hommey [:glandium]]

Weird, I thought I had filed this bug. It's also not possible to retrigger a decision task, IIRC. I'm moving this to task configuration, but I'm not actually sure where this would need to be fixed. Maybe treeherder?

Comment 2

[Andrew Halberstadt [:ahal]]

I'll leave it up to Tom to triage, but I suspect this is going to be a WONTFIX. The action tasks we use to handle things like Cancel and Retrigger depend on artifacts from the decision task. Fixing this would mean breaking a lot of assumptions and/or implementing an entirely new way of canceling tasks that runs out-of-tree (i.e what we did prior to Action tasks). My understanding is that there were serious problems with the old approach and revisiting it isn't likely to happen.

Maybe treeherder could do something smart, like queue up a "Cancel All" task that runs as soon as the decision task is finished though.

Comment 3

[Mike Hommey [:glandium]]

... or just call the taskcluster cancel API for decision tasks.

Comment 4

[Tom Prince [:tomprince]]

This would require support from treeherder. The action specification does suggest that in the absence of a decision task with an actions.json, that the taskcluster UI should fall back to hard-coded implementations. I'm not sure if this makes sense for treeherder do do as well.