1601880 - Add page orientation parameter to snippets preview

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Giorgos Logiotatidis [:giorgos]]

We want Arabic to display correctly in all Snippet Templates. Prioritize the Simple Snippet and the Simple Snippet Bellow Search bar templates if you tackle each one separately.

Thanks!

Comment 1

[Andrei Oprea [:andreio]]

Confirmed that this is in fact an issue with the preview feature.
The fix we agreed on was to add a new query parameter similar to how theme works and would flip the page to RTL mode.
This parameter will be used by the snippets preview tool to select the correct layout.

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1601880 - Added page orientation param to Snippets preview, plus a test for same

The URLSearchParams now has a property "dir", which can be set to "rtl" to preview right-to-left orientation

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emcminn, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Emily McMinn :emcminn]

@andreio, would you be able to land this for me? No rush :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a1dc2b6e104
Added page orientation param to Snippets preview, plus a test for same r=andreio

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a1dc2b6e104

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Does this need Beta uplift or can it ride Fx74 to release?

Comment 8

[Emily McMinn :emcminn]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Does this need Beta uplift or can it ride Fx74 to release?

My impression is that since it only affects the preview feature (not anything user-facing), it's okay for it to ride the trains. :)

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (74.0a1 Build ID - 20200205055433) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, the below search bar snippet respects the page orientation.
In order to verify this issue I've used the following steps:

1. Create the browser.newtab.activity-stream.asrouter.whitelistHosts pref with the ["gist.githubusercontent.com"] value in the "about:config" page.
2. Switch the browser.newtabpage.activity-stream.feeds.asrouterfeed pref's value to false and back to true.
3. Navigate to about:newtab?endpoint=https://gist.githubusercontent.com/piatra/3029b3336c2df8f64ebb72ca3e027bae/raw/503c53e41a748fd6d1b2be1cd11e45e8c2e49e1b/endpoint.json&dir=rtl .