1601897 - Some more loop cleanups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

A few things not covered by other bugs.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1601897 part 1 - Remove unused LoopControl::loopEndOffset_. r?arai!

No longer used since bug 1598548.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1601897 part 2 - Move patchBreaks and addTryNote calls to LoopControl::emitLoopEnd. r?arai!

This ensures all loops handle this the same way.

For JSTRY_FOR_IN some places asserted the try note ends at the
JSOP_ENDITER and includes the JSOP_JUMPTARGET and JSOP_POP, but
I don't think we need to preserve that invariant.

The next patch will improve HasLiveStackValueAtDepth because
I think there might be a (pre-existing) issue with emitSpread.

Depends on D56171

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1601897 part 3 - Improve and simplify HasLiveStackValueAtDepth. r?arai!

Instead of depending on the meaning of specific for-in/for-of stack slots it's
simpler, safer and more robust to keep all loop stack slots alive when we have
a debugger exception bailout.

Depends on D56172

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1601897 part 4 - Let JSOP_ENDITER pop the iterator value too. r?arai!

This way we don't need a separate JSOP_POP.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a9ab8423e85
part 1 - Remove unused LoopControl::loopEndOffset_. r=arai
https://hg.mozilla.org/integration/autoland/rev/7a3a4207c55b
part 2 - Move patchBreaks and addTryNote calls to LoopControl::emitLoopEnd. r=arai
https://hg.mozilla.org/integration/autoland/rev/0d4e8d749b8d
part 3 - Improve and simplify HasLiveStackValueAtDepth. r=arai
https://hg.mozilla.org/integration/autoland/rev/8b5fbd3c4347
part 4 - Let JSOP_ENDITER pop the iterator value too. r=arai

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7a9ab8423e85
https://hg.mozilla.org/mozilla-central/rev/7a3a4207c55b
https://hg.mozilla.org/mozilla-central/rev/0d4e8d749b8d
https://hg.mozilla.org/mozilla-central/rev/8b5fbd3c4347