1602048 - Cleanup Abstract Scope

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

After addressing some review comments for AbstractScope, I introduced some tidy-able issues with it that were caught by reviewbot

• Use = default to define a trivial default constructor for AbstractScope
• Function js::LexicalScope::nextFrameSlot has a definition with different parameter names, so the parameter names should me made the same.

Comment 1

[Mahak]

hello Sir,
I'm new to open soure so can you tell me how can I pull the code of this issue?

Comment 2

[Michael Wilson]

Mahak https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

I am setting up my dev environment and am going to poach this bug unless I hear from someone. Really looking forward to getting the workflow down and sinking my teeth in.

Comment 3

[shivambalikondwar]

Michael I would like to give it a try, I have contributed to Mozilla in past year and will work on it. Let me know what channel of irc you are available for clearing some doubts.

Comment 4

[Michael Wilson]

shivambalikondwar, if you want this one, that is fine with me. But, if I don't see a patch in the next few days, I'm going to submit one. Thanks.

Comment 5

[shivambalikondwar]

@micheal I am am working on this, if you complete it then yes i won't mind. Sorry for the delayed response.

Comment 6

[sjdhanvij1998]

hello , i am new to open source coding. The above link is not working as to how i can do a pull request for the code. can someone help me.

Comment 7

[Michael Wilson]

sjdhanvij1998, Firefox code is hosted in one location, and other tools are used for code reviews. I have found these two resources to be the best. It took me most of an afternoon to get everything setup and submit my first (really trivial patch).

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Good luck and welcome!

Comment 8

[sanchit.arora.2002]

Can I work on this bug if it's still available?

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Definitely, a patch is welcome: Note that only the mismatched parameter names still appear in the code.

Comment 10

[sanchit.arora.2002]

Attachment: Bug 1602048 - Change parameter name of js::LexicalScope::nextFrameSlot. r=tcampbell

Depends on D60347

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3396e5b2a24f
Change parameter name of js::LexicalScope::nextFrameSlot. r=tcampbell

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3396e5b2a24f