Closed Bug 1602048 Opened 4 months ago Closed 2 months ago

Cleanup Abstract Scope

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mgaudet, Assigned: sanchit.arora.2002, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(1 file)

After addressing some review comments for AbstractScope, I introduced some tidy-able issues with it that were caught by reviewbot

  • Use = default to define a trivial default constructor for AbstractScope
  • Function js::LexicalScope::nextFrameSlot has a definition with different parameter names, so the parameter names should me made the same.
Priority: -- → P2

hello Sir,
I'm new to open soure so can you tell me how can I pull the code of this issue?

Mahak https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

I am setting up my dev environment and am going to poach this bug unless I hear from someone. Really looking forward to getting the workflow down and sinking my teeth in.

Michael I would like to give it a try, I have contributed to Mozilla in past year and will work on it. Let me know what channel of irc you are available for clearing some doubts.

shivambalikondwar, if you want this one, that is fine with me. But, if I don't see a patch in the next few days, I'm going to submit one. Thanks.

@micheal I am am working on this, if you complete it then yes i won't mind. Sorry for the delayed response.

hello , i am new to open source coding. The above link is not working as to how i can do a pull request for the code. can someone help me.

sjdhanvij1998, Firefox code is hosted in one location, and other tools are used for code reviews. I have found these two resources to be the best. It took me most of an afternoon to get everything setup and submit my first (really trivial patch).

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Good luck and welcome!

Can I work on this bug if it's still available?

Flags: needinfo?(mgaudet)

Definitely, a patch is welcome: Note that only the mismatched parameter names still appear in the code.

Flags: needinfo?(mgaudet)
Assignee: nobody → sanchit.arora.2002
Status: NEW → ASSIGNED
Attachment #9121749 - Attachment description: Bug 1602048 - Changed parameter name of js::LexicalScope::nextFrameSlot. r=tcampbell → Bug 1602048 - Change parameter name of js::LexicalScope::nextFrameSlot. r=tcampbell
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3396e5b2a24f
Change parameter name of js::LexicalScope::nextFrameSlot. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.