Closed Bug 1602066 Opened 1 year ago Closed 1 year ago

Investigate if ESLint could support self-closing script tags in xhtml files

Categories

(Firefox Build System :: Lint and Formatting, task, P2)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Iteration:
73.1 - Dec 2 - Dec 15
Tracking Status
firefox73 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Currently ESLint doesn't support self-closing script tags in xhtml files. This means that the automatic importing of globals from other files doesn't work correctly.

We should see if we can make this work, or if we need to change our xhtml files.

I've found a solution for this - change our HTML parser into XML mode for xhtml files. I just looked and this happens to be the same as what eslint-plugin-html does for xhtml files, so I think we're good for that.

Assignee: nobody → standard8
Iteration: --- → 73.1 - Dec 2 - Dec 15
Blocks: 1602364

This helps finding globals for files as we can find out more information about the scripts they include.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55166b4ae65b
For ESLint, treat all xhtml files as xml files for parsing when we're looking for script tags. r=bgrins
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.