1602083 - Emit executionContextCreated for all contexts that exist when Runtime gets enabled

Status: RESOLVED WONTFIX

(Remote Protocol :: CDP, enhancement, P2)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

https://chromedevtools.github.io/devtools-protocol/tot/Runtime#method-enable: "When the reporting gets enabled the event will be sent immediately for each existing execution context." implying that contexts get created regardless of whether Runtime is enabled or not; "enabled" just means notifications are being sent.

So in Runtime.enabled we should iterate over contexts and emit an executionContextCreated event for all the contexts that already exist.

This is especially relevant to methods like Page.createIsolatedWorld and Page.addScriptToEvaluateOnNewDocument, since they create new execution contexts in addition to what Runtime does.

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Related to this, I think this also implies that we need to move the turning on/off of the context observer for context-created and context-destroyed out of Runtime. Contexts should be destroyed/created regardless of whether the Runtime domain is instantiated or not.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Node that a couple of tests have to use Runtime.enabled to workaround this bug, and need to be updated with the fix.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

This is blocked by bug 1623482 and cannot be mentored at the moment.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

This seems to be important for clients.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

We are not going to implement this. One should use WebDriver BiDi these days.