Closed Bug 1602088 Opened 4 months ago Closed 2 months ago

Move nsIScrollableFrame::ScrollUnit to namespace scope

Categories

(Core :: Layout: Scrolling and Overflow, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: botond, Assigned: u7693, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This would allow us to move the declaration of ScrollUnit to a different file (e.g. ScrollTypes.h), and thereby avoid e.g. InputData.h (a commonly included header) having to include nsIScrollableFrame.h (which brings in a lot of other headers).

Mentor: botond
Keywords: good-first-bug

As part of this change, we should probably change ScrollUnit to be an enum class, so that its enumerator names are not introduced into namespace scope.

Assignee: nobody → u7693
Status: NEW → ASSIGNED
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69fded25adc2
Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond

^ I think this is an unrelated intermittent failure. The retriggers of the test job in question are all passing.

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ba3576a0761
Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond

Sorry about this Botond, relanded the patch.

Flags: needinfo?(u7693)
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.