1602088 - Move nsIScrollableFrame::ScrollUnit to namespace scope

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task)

Description

[Botond Ballo [:botond]]

This would allow us to move the declaration of ScrollUnit to a different file (e.g. ScrollTypes.h), and thereby avoid e.g. InputData.h (a commonly included header) having to include nsIScrollableFrame.h (which brings in a lot of other headers).

Comment 1

[Botond Ballo [:botond]]

As part of this change, we should probably change ScrollUnit to be an enum class, so that its enumerator names are not introduced into namespace scope.

Comment 2

[Kousuke Takaki]

Attachment: Bug 1602088 - Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69fded25adc2
Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cdebug%2Creftests%2Ctest-windows10-64%2Fdebug-reftest-e10s-2%2Cr%28r2%29&revision=69fded25adc2ac25e302b49c1128f8926e1311a3&selectedJob=286949730

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286949730&repo=autoland
Reftest analyzer: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DxUnlHUJS52lMFV07Y8icQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Backout link: https://hg.mozilla.org/integration/autoland/rev/641d24ccb2f69c69b13aff168d983ec057857807

Comment 5

[Botond Ballo [:botond]]

^ I think this is an unrelated intermittent failure. The retriggers of the test job in question are all passing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ba3576a0761
Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond

Comment 7

[Cosmin Sabou [:CosminS]]

Sorry about this Botond, relanded the patch.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4ba3576a0761