Closed Bug 1602103 Opened 2 years ago Closed 2 years ago

Set the print job name before initialization of the print session on macOS

Categories

(Core :: Printing: Setup, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v73])

Attachments

(1 file)

No description provided.

For a PMSession to be given a job name, the job name must be set on the
PMPrintSettings before it is passed to PMSessionBeginCGDocumentNoDialog.
However, since nsDeviceContext::BeginDocument calls PrintTarget::BeginPrinting
before calling nsDeviceContextSpec::BeginDocument, the setting of the job name
in nsDeviceContextSpecX::BeginDocument was happening after the
PMSessionBeginCGDocumentNoDialog call in PrintTargetCG::BeginPrinting, and was
doing us no good. This moves the job name setting into
PrintTargetCG::BeginPrinting so that the job name is set first.

Note: The job name is shown if your printer/OS has software to manage the list
of queued jobs waiting to print.

Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/524128dc119c
Set the print job name before initialization of the print session on macOS. r=bobowen
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Blocks: 1601775

I believe this bug caused a regression at bug 1606512

(In reply to fiveNinePlusR from comment #4)

I believe this bug caused a regression at bug 1606512

Thank you. (For future reference, using the "Request information from" field to attract the attention of the person that made the change is helpful. :) )

Regressions: 1606512
No longer regressions: 1606512
Whiteboard: [print_v73]
Whiteboard: [print_v73] → [print2020_v73]
You need to log in before you can comment on or make changes to this bug.