1602103 - Set the print job name before initialization of the print session on macOS

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P3)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1602103. Set the print job name before initialization of the print session on macOS. r=bobowen

For a PMSession to be given a job name, the job name must be set on the
PMPrintSettings before it is passed to PMSessionBeginCGDocumentNoDialog.
However, since nsDeviceContext::BeginDocument calls PrintTarget::BeginPrinting
before calling nsDeviceContextSpec::BeginDocument, the setting of the job name
in nsDeviceContextSpecX::BeginDocument was happening after the
PMSessionBeginCGDocumentNoDialog call in PrintTargetCG::BeginPrinting, and was
doing us no good. This moves the job name setting into
PrintTargetCG::BeginPrinting so that the job name is set first.

Note: The job name is shown if your printer/OS has software to manage the list
of queued jobs waiting to print.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/524128dc119c
Set the print job name before initialization of the print session on macOS. r=bobowen

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/524128dc119c

Comment 4

[fiveNinePlusR]

I believe this bug caused a regression at bug 1606512

Comment 5

[Jonathan Watt [:jwatt]]

(In reply to fiveNinePlusR from comment #4)

I believe this bug caused a regression at bug 1606512

Thank you. (For future reference, using the "Request information from" field to attract the attention of the person that made the change is helpful. :) )