1602200 - Adoption and DocumentFragment

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Anne (:annevk)]

We need to make various changes to how we deal with adoption, in particular of DocumentFragment.

See https://github.com/whatwg/dom/pull/754 and https://github.com/web-platform-tests/wpt/pull/16348 (not merged yet, see bug 1602198 for wpt-sync).

Comment 1

[John Dai[:jdai]]

I have a patch on my local, so put this bug in my queue. I'll take care of it. :)

Comment 2

[John Dai[:jdai]]

There are https://github.com/whatwg/dom/issues/813 and https://github.com/whatwg/dom/issues/819 are unresolved. I'll hold off fixing this bug.

Comment 3

[Anne (:annevk)]

I posted a new fix at https://github.com/whatwg/dom/pull/819 that I'd appreciate review on.

Comment 4

[Karl Dubost💡 :karlcow]

To note that this creates a webcompat issue for a JS library, and that WebKit might need to revert the implementation.
See the discussions in https://github.com/whatwg/dom/pull/819
and https://github.com/aurelia/framework/issues/1003
https://bugs.webkit.org/show_bug.cgi?id=204980

Chromium bug is:
https://bugs.chromium.org/p/chromium/issues/detail?id=1031811

As of today
https://bug-246899-attachments.webkit.org/attachment.cgi?id=463188

STP 164

fragment.ownerDocument.documentElement: null
Then document.adoptNode(fragment);
fragment.ownerDocument.documentElement null

Firefox Nightly 112.0a1 (2023-03-02)

fragment.ownerDocument.documentElement: null
Then document.adoptNode(fragment);
fragment.ownerDocument.documentElement [object HTMLHtmlElement]

Chrome Canary 113.0.5627.0

fragment.ownerDocument.documentElement: null
Then document.adoptNode(fragment);
fragment.ownerDocument.documentElement [object HTMLHtmlElement]