Closed Bug 1602222 Opened 4 months ago Closed 4 months ago

Use consistent definition of JSScript::IsModule / LazyScript::IsModule

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(2 files)

LazyScript::isModule is true for all inner functions of a module, while JSScript only sets it for the top-level. This needs to be fixed for Bug 1529456.

The fix here might be add a flag to the scriptSource to cover all-scripts-within-a-module.

Lazy scripts were using the IsModule flag with different semantics than
compiled scripts and so this patch adds a new flag instead. The flag is
initialized from non-lazy scripts for consistency.

Assignee: nobody → tcampbell
Status: NEW → ASSIGNED
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42f003a50150
Add HasModuleGoal flag to js::BaseScript. r=jandem
https://hg.mozilla.org/integration/autoland/rev/887237f5f3e0
Move LazyScript::parseGoal() to BaseScript. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Regressions: 1604792
You need to log in before you can comment on or make changes to this bug.