Closed
Bug 1602257
Opened 6 years ago
Closed 6 years ago
Update build configs for gitlab SeaMonkey 2.53
Categories
(SeaMonkey :: Build Config, enhancement)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.53 fixed)
RESOLVED
FIXED
seamonkey2.53
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.53 | --- | fixed |
People
(Reporter: frg, Assigned: frg)
References
Details
(Whiteboard: SM2.53.1)
Attachments
(4 files, 1 obsolete file)
|
255 bytes,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
17.59 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
1.37 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
754 bytes,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
We need to update the gitignore files.
|
Assignee | |
Comment 1•6 years ago
|
||
Initial patch for comm-release gitlab 2.53
Attachment #9114389 -
Flags: review?(iann_bugzilla)
Attachment #9114389 -
Flags: approval-comm-release?
|
|
Assignee | |
Comment 2•6 years ago
|
||
Initial patch from IanN for gitlab mozilla-release
r/a=me
Attachment #9114390 -
Flags: review+
Attachment #9114390 -
Flags: approval-comm-release+
Comment on attachment 9114389 [details] [diff] [review]
1602257-gitlab.patch
[Triage Comment]
LGTM r/a=me
Attachment #9114389 -
Flags: review?(iann_bugzilla)
Attachment #9114389 -
Flags: review+
Attachment #9114389 -
Flags: approval-comm-release?
Attachment #9114389 -
Flags: approval-comm-release+
|
|
Assignee | |
Comment 4•6 years ago
|
||
Followup for comm-release patch.
I assumed that the hgignore syntax was identical to gitignore. That was plain wrong. Part 1 is already in gitlab so do a part 2.
Attachment #9117604 -
Flags: review?(iann_bugzilla)
Attachment #9117604 -
Flags: approval-comm-release?
Comment on attachment 9117604 [details] [diff] [review]
1602257-2-gitlab.patch
> # SVN directories
>-\.svn/
>-
>-# Git repositories
>-.git/
>+/.svn/
Do we need to ignore Mercurial respositories?
r/a=me with that answered/addressed
Attachment #9117604 -
Flags: review?(iann_bugzilla)
Attachment #9117604 -
Flags: review+
Attachment #9117604 -
Flags: approval-comm-release?
Attachment #9117604 -
Flags: approval-comm-release+
|
|
Assignee | |
Comment 6•6 years ago
|
||
We do not have .hg repos in the comm-release source. Same for .svn so we can remove this too.
Updated patch r/a+ from IanN retained.
Attachment #9117604 -
Attachment is obsolete: true
Attachment #9117996 -
Flags: review+
Attachment #9117996 -
Flags: approval-comm-release+
|
|
Assignee | |
Comment 7•6 years ago
|
||
the mozilla .gitignore was missing cZ and DOMi. r/a+ from IanN over irc.
Attachment #9117999 -
Flags: review+
Attachment #9117999 -
Flags: approval-comm-release+
|
|
Assignee | |
Comment 8•6 years ago
|
||
Fixed in 2.53.1 beta branches:
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/tree/2_53_beta_01:
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/tree/2_53_beta_01
Target Milestone: --- → seamonkey2.53
|
|
Assignee | |
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Updated•1 year ago
|
Version: SeaMonkey 2.53 Branch → SeaMonkey 2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•