Closed
Bug 1602258
Opened 5 years ago
Closed 5 years ago
make WheelHandlingUtils::CanScrollOn use GetAvailableScrollingDirectionsForUserInputEvents
Categories
(Core :: Panning and Zooming, task, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla73
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(3 files)
See the comments on https://phabricator.services.mozilla.com/D55918
Assignee | ||
Comment 1•5 years ago
|
||
This should give two improvements:
- CanScrollOn will not report that the user can scroll in an overflow hidden direction.
- CanScrollOn will report that the user can scroll in an overflow hidden direction if the document is pinch zoomed in so that the user can scroll around the layout viewport.
Updated•5 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•5 years ago
|
||
This is similar to GetAvailableScrollingDirections but also takes into account any resolution.
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D56301
Updated•5 years ago
|
Attachment #9116661 -
Attachment description: Bug 1602258. Make ScrollFrameHelper::GetAvailableScrollingDirectionsForUserInputEvents check for one screen pixel of scroll range instead of one app unit. r?botond → Bug 1602258. Make ScrollFrameHelper::GetAvailableScrollingDirectionsForUserInputEvents check for at least half a screen pixel of scroll range instead of one app unit. r?botond
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/510528109a46
Make ScrollFrameHelper::GetAvailableScrollingDirectionsForUserInputEvents check for at least half a screen pixel of scroll range instead of one app unit. r=botond
https://hg.mozilla.org/integration/autoland/rev/392f9daee09b
Use GetAvailableScrollingDirectionsForUserInputEvents in WheelHandlingUtils::CanScrollOn. r=botond
https://hg.mozilla.org/integration/autoland/rev/ad7e08d48841
Remove GetAvailableVisualScrollingDirections, it is unused. r=botond
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/510528109a46
https://hg.mozilla.org/mozilla-central/rev/392f9daee09b
https://hg.mozilla.org/mozilla-central/rev/ad7e08d48841
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•