160227 - VERSION cookie not set correctly

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Bradley Baetz (:bbaetz)]

The VERSION-$product cookie which post_bug sets is now only a session cookie. I
looked into this, and it appears that apache is printing

               path=/bugzilla/ ; expires=Sun, 30-Jun-2029 00: 00:00 GMT
Set-Cookie: VERSION-Foo=0.999 ; 

Note that the path/expires is _above_ the Set-Cookie line (and on a different
line, too). This is from a network trace; its not a browser thing. This means
that the path/expires stuff isn't used, so it becomes a session cookie, and if
the path isn't / then it won't be used at all (because an existing cookie for
the real path is more specific)

It appears apache is converting the \<nl> in our set-cookie line into the
_opposite_ of a CR, possibly due to the unix line ending?? I'm seeing this on
bmo too, so its not a local thing.

Anyway, the fix is to just use . to concatenate the two strings. I'd love an
explanation, though.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: v1

Comment 2

[Bradley Baetz (:bbaetz)]

This is a regression. Have we decided whether or not to check fixes for these
into the 2.16 branch or not, btw?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 93349 [details] [diff] [review]
v1

Yup, regression.  Yup, this fixes it.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 93349 [details] [diff] [review]
v1

Just in case the 2.16 branch needs second reviews, here's 2xr=myk.

Comment 5

[Bradley Baetz (:bbaetz)]

This has been checked into the trunk; I've posted to the bugzilla list to
discuss 2.16.1, and I may check it in there after that.

Leaving open for a few days to come to a conclusion.

Comment 6

[Bradley Baetz (:bbaetz)]

OK, checked in on teh 2.16 branch too