Closed Bug 1602279 Opened 6 years ago Closed 6 years ago

Intermittent GECKO(1767) | Assertion failure: !IsPending(), at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MozPromise.h:1074

Categories

(External Software Affecting Firefox :: Telemetry, defect, P3)

Product:
External Software Affecting Firefox
Component:
Telemetry
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox71 unaffected, firefox72 unaffected, firefox73 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- unaffected
firefox73 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1602279: Do not return early from UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess without rejecting its promise; r=mhowell
47 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1502623 +++

These latest failures here are a regression from Bug 1522830 and it causes crashes on windows debug reftests [@ mozilla::MozPromise<mozilla::Maybe<mozilla::UntrustedModulesProcessor::ModulesMapResultWithLoads>,nsresult,1>::~MozPromise()]
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-12-01&endday=2019-12-08&tree=trunk&bug=1502623

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280118165&repo=mozilla-central&lineNumber=20669

It has quite a high occurrence rate: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=Windows%2C10%2Cx64%2CCCov%2Cdebug%2CReftests%2Ctest-windows10-64-ccov%2Fdebug-reftest-e10s&fromchange=0d24f14c08476bc68595f38ad28ac1f34085d862&selectedJob=280118165

[task 2019-12-07T12:09:50.954Z] 12:09:50 INFO - Assertion failure: !IsPending(), at z:/build/build/src/obj-firefox/dist/include\mozilla/MozPromise.h:1021
[task 2019-12-07T12:09:51.101Z] 12:09:51 INFO - ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-12-07T12:10:39.320Z] 12:10:39 INFO - #01: mozilla::MozPromiseRefcountable::Release() [xpcom/threads/MozPromise.h:145]
[task 2019-12-07T12:10:39.320Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.320Z] 12:10:39 INFO - #02: mozilla::UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess(mozilla::UntrustedModulesProcessor::Priority) [toolkit/xre/UntrustedModulesProcessor.cpp:788]
[task 2019-12-07T12:10:39.320Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.321Z] 12:10:39 INFO - #03: mozilla::UntrustedModulesProcessor::BackgroundProcessModuleLoadQueueChildProcess() [toolkit/xre/UntrustedModulesProcessor.cpp:502]
[task 2019-12-07T12:10:39.321Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.321Z] 12:10:39 INFO - #04: mozilla::UntrustedModulesProcessor::ProcessModuleLoadQueue() [toolkit/xre/UntrustedModulesProcessor.cpp:549]
[task 2019-12-07T12:10:39.321Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.322Z] 12:10:39 INFO - #05: mozilla::UntrustedModulesProcessor::BackgroundProcessModuleLoadQueue() [toolkit/xre/UntrustedModulesProcessor.cpp:451]
[task 2019-12-07T12:10:39.322Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.322Z] 12:10:39 INFO - #06: nsresult mozilla::detail::RunnableMethodImpl<mozilla::UntrustedModulesProcessor ,void (mozilla::UntrustedModulesProcessor::)(),1,mozilla::RunnableKind::Standard>::Run() [xpcom/threads/nsThreadUtils.h:1176]
[task 2019-12-07T12:10:39.322Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.323Z] 12:10:39 INFO - #07: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1250]
[task 2019-12-07T12:10:39.323Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.323Z] 12:10:39 INFO - #08: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:486]
[task 2019-12-07T12:10:39.323Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.324Z] 12:10:39 INFO - #09: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:332]
[task 2019-12-07T12:10:39.324Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.324Z] 12:10:39 INFO - #10: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:315]
[task 2019-12-07T12:10:39.324Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.324Z] 12:10:39 INFO - #11: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:309]
[task 2019-12-07T12:10:39.324Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.325Z] 12:10:39 INFO - #12: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2019-12-07T12:10:39.325Z] 12:10:39 INFO -
[task 2019-12-07T12:10:39.325Z] 12:10:39 INFO - #13: nsThread::ThreadFunc(void *) [xpcom/threads/nsThread.cpp:460]
[task 2019-12-07T12:10:39.325Z] 12:10:39 INFO -
[task 2019-12-07T12:10:43.307Z] 12:10:43 INFO - #14: PR_NativeRunThread [nsprpub/pr/src/threads/combined/pruthr.c:408]
[task 2019-12-07T12:10:43.307Z] 12:10:43 INFO -
[task 2019-12-07T12:10:43.307Z] 12:10:43 INFO - #15: static unsigned int pr_root(void *) [nsprpub/pr/src/md/windows/w95thred.c:140]
[task 2019-12-07T12:10:43.307Z] 12:10:43 INFO -
[task 2019-12-07T12:10:43.308Z] 12:10:43 INFO - #16: ucrtbase.dll + 0x1c4be
[task 2019-12-07T12:10:43.308Z] 12:10:43 INFO -
[task 2019-12-07T12:10:43.308Z] 12:10:43 INFO - #17: KERNEL32.DLL + 0x13034
[task 2019-12-07T12:10:43.308Z] 12:10:43 INFO -
[task 2019-12-07T12:10:43.451Z] 12:10:43 INFO - #18: static void patched_BaseThreadInitThunk(int, void *, void *) [mozglue/dllservices/WindowsDllBlocklist.cpp:583]
[task 2019-12-07T12:10:43.451Z] 12:10:43 INFO -
[task 2019-12-07T12:10:43.452Z] 12:10:43 INFO - #19: ntdll.dll + 0x71461
[task 2019-12-07T12:10:43.452Z] 12:10:43 INFO -
[task 2019-12-07T12:10:43.453Z] 12:10:43 INFO - [Child 8216, Main Thread] WARNING: '!mIOThread', file z:/build/build/src/xpcom/io/nsSegmentedBuffer.cpp, line 165
[task 2019-12-07T12:10:43.454Z] 12:10:43 INFO - [Child 8216, Main Thread] WARNING: '!mIOThread', file z:/build/build/src/xpcom/io/nsSegmentedBuffer.cpp, line 165
[task 2019-12-07T12:10:43.454Z] 12:10:43 INFO - [Child 8216, Main Thread] WARNING: '!mIOThread', file z:/build/build/src/xpcom/io/nsSegmentedBuffer.cpp, line 165
[task 2019-12-07T12:10:43.455Z] 12:10:43 INFO - [Child 8216, Main Thread] WARNING: '!mIOThread', file z:/build/build/src/xpcom/io/nsSegmentedBuffer.cpp, line 165
[task 2019-12-07T12:10:43.456Z] 12:10:43 INFO - [Child 8216, Main Thread] WARNING: '!mIOThread', file z:/build/build/src/xpcom/io/nsSegmentedBuffer.cpp, line 165
[task 2019-12-07T12:10:43.456Z] 12:10:43 INFO - [Child 8216, Main Thread] WARNING: '!mIOThread', file z:/build/build/src/xpcom/io/nsSegmentedBuffer.cpp, line 165
[task 2019-12-07T12:10:43.457Z] 12:10:43 INFO - nsStringStats
[task 2019-12-07T12:10:43.458Z] 12:10:43 INFO - => mAllocCount: 9189
[task 2019-12-07T12:10:43.458Z] 12:10:43 INFO - => mReallocCount: 0
[task 2019-12-07T12:10:43.459Z] 12:10:43 INFO - => mFreeCount: 9189
[task 2019-12-07T12:10:43.460Z] 12:10:43 INFO - => mShareCount: 8861
[task 2019-12-07T12:10:43.460Z] 12:10:43 INFO - => mAdoptCount: 533
[task 2019-12-07T12:10:43.461Z] 12:10:43 INFO - => mAdoptFreeCount: 539
[task 2019-12-07T12:10:43.462Z] 12:10:43 INFO - => Process ID: 8216, Thread ID: 1100
[task 2019-12-07T12:10:43.462Z] 12:10:43 INFO - [Child 432, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file z:/build/build/src/layout/base/nsPresContext.cpp, line 847
[task 2019-12-07T12:10:43.463Z] 12:10:43 INFO - [Child 432, Main Thread] WARNING: '!aWin', file z:/build/build/src/dom/base/Document.cpp, line 1378
[task 2019-12-07T12:10:43.463Z] 12:10:43 INFO - [Child 432, Main Thread] WARNING: '!aWin', file z:/build/build/src/dom/base/Document.cpp, line 1378
[task 2019-12-07T12:10:43.465Z] 12:10:43 INFO - REFTEST INFO | drawWindow flags = DRAWWINDOW_DRAW_CARET | DRAWWINDOW_DRAW_VIEW | DRAWWINDOW_USE_WIDGET_LAYERS; window size = 816,1039; test browser size = 800,1000
[task 2019-12-07T12:10:43.466Z] 12:10:43 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1575715529/build/tests/reftest/tests/layout/reftests/svg/as-image/zoom/img-zoomIn-1.html == file:///Z:/task_1575715529/build/tests/reftest/tests/layout/reftests/svg/as-image/zoom/squaredCircle-150x150-ref.html | crash-check | This test left crash dumps behind, but we weren't expecting it to!

When we return early without doing anything with |p|, we trigger all kinds of
assertions when |p| is destroyed. Once we have allocated |p|, we unconditionally
proceed with using it.

Assignee: nobody → aklotz
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de59a612c6e5 Do not return early from UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess once its promise has been created; r=mhowell
Attachment #9114620 - Attachment description: Bug 1602279: Do not return early from UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess once its promise has been created; r=mhowell → Bug 1602279: Do not return early from UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess without rejecting its promise; r=mhowell
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b782f7285bb4 Do not return early from UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess without rejecting its promise; r=mhowell

https://hg.mozilla.org/mozilla-central/rev/b782f7285bb4

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: