1602319 - Firefox Nightly add to favorites not working as expected on Ubuntu 18.04

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Rick]

Attachment: nightly_ubuntu_favorites_problem.gif

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

1. Installed firefox nightly according to this guide (https://support.mozilla.org/en-US/questions/924510)
2. In the Dock right mouse click the firefox nightly icon and click add to favorites.
3. The firefox nightly icon is now added to favorites.
4. Click the nightly icon to open firefox nightly.

Actual results:

When clicking on the nightly icon a new nightly icon appears in the dock and becomes active.

Expected results:

I expected the nightly favorites icon to be activated instead of a new nightly icon appearing.

Comment 1

[Seba S.]

Hi, rick.staa!

Thanks for your contribution!

I couldn't reproduce the described behavior in:

Ubuntu 18.04.3 LTS
Firefox 68.0 (64.bit)
Nightly 73.0a1(2019-12-07)

Please let us know if this issue is reproduced in the latest Nightly edition. You can download it from here: https://nightly.mozilla.org/

If you still have the issue please create a new profile, you have the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager
support.mozilla.orgsupport.mozilla.org

Once you have all this information, please let us know so we can continue investigating.

Regards,

Comment 2

[Rick]

Dear Seba,

Thanks for your answer. I just verified the problem had indeed been fixed in the 73.0a1 (2019-12-12) (64-bit) build.

Regards,
Rick,

Comment 3

[Rick]

Dear Seb
(In reply to rick.staa from comment #2)

Dear Seba,

Thanks for your answer. I just verified the problem had indeed been fixed in the 73.0a1 (2019-12-12) (64-bit) build.

Regards,
Rick,

I just double checked and my previos post is incorrect. It still isn't working I now also don't have an add to favorites option when right clicking on the firefox nightly icon in the taskbar. I install the firefox nightly browser using the firefox-trunk ppa.

Thanks in advance,
Greetings,
Rick,

Comment 4

[Rick]

(In reply to rick.staa from comment #3)

Dear Seb
(In reply to rick.staa from comment #2)

Dear Seba,

Thanks for your answer. I just verified the problem had indeed been fixed in the 73.0a1 (2019-12-12) (64-bit) build.

Regards,
Rick,

I just double checked and my previos post is incorrect. It still isn't working I now also don't have an add to favorites option when right clicking on the firefox nightly icon in the taskbar. I install the firefox nightly browser using the firefox-trunk ppa.

Thanks in advance,
Greetings,
Rick,

The problem also persists when creating a new profile. This might something to do with the fact that I can only add the firefox-nightly to my favorites through the Ubuntu application menu.

Comment 5

[Seba S.]

Hi rick.staa,

I couldn't reproduce this issue, I've tested on Ubuntu 18 and 16 and couldn´t reach the described behavior. Also, I tried both installation types, meaning from the terminal and using it from the downloaded folder without installing the desktop application and also downloading the official version in the ubuntu application manager.

I'll add product and component on this in order to keep researching if you could try on the latest Firefox version again would be great!

Regards,

Comment 6

[:Gijs (away/busy until Mar 10)]

I have no idea how Ubuntu deals with "Favorites" but it's unrelated to Firefox's own toolbars (which is what this component is for).

Hopefully our gtk/linux integration experts have more of an idea (though I'm not sure if widget is the best place for this, either - it would be on Windows, as taskbar groupings are controlled through our widget code...). If I had to guess, I'd expect the issue is to do with either .desktop files or the firefox wrapper script around firefox-bin, or something. :glandium, perhaps you know?

Comment 7

[Mike Hommey [:glandium]]

Sounds like it, although I'm not sure what this "Favorites" feature is. Comment 0 talks about a Dock, is that Unity?

Comment 8

[Mike Hommey [:glandium]]

Oh, the screencast does look like Unity. Gnome Shell has something similar, but as far as testing on my machine goes, there is no "Add to Favorites" menu item when running firefox from a downloaded mozilla.org build. It seems to rely on a .desktop file existing. So maybe this bug is an issue with the .desktop file shipped in whatever package you're using? (presumably, StartupWMClass)

Comment 9

[Rick]

(In reply to Mike Hommey [:glandium] from comment #8)

Oh, the screencast does look like Unity. Gnome Shell has something similar, but as far as testing on my machine goes, there is no "Add to Favorites" menu item when running Firefox from a downloaded mozilla.org build. It seems to rely on a .desktop file existing. So maybe this bug is an issue with the .desktop file shipped in whatever package you're using? (presumably, StartupWMClass)

(In reply to :Gijs (he/him) from comment #6)

I have no idea how Ubuntu deals with "Favorites" but it's unrelated to Firefox's own toolbars (which is what this component is for).

Hopefully our gtk/linux integration experts have more of an idea (though I'm not sure if widget is the best place for this, either - it would be on Windows, as taskbar groupings are controlled through our widget code...). If I had to guess, I'd expect the issue is to do with either .desktop files or the firefox wrapper script around firefox-bin, or something. :glandium, perhaps you know?

Dear Gijs and Mike. Thanks a lot for looking into the issue. The env | grep XDG_CURRENT_DESKTOP command gives the following output XDG_CURRENT_DESKTOP=ubuntu:GNOME. I also noticed that there is not "Add to Favorites" menu item when running Firefox nightly. I, therefore, used the "Show applications" tab to add Firefox nightly to favourites. I think this is where things go wrong as the new favourites toolbar icon now links to another firefox profile than my default firefox profile. As a result, when I open Firefox, it does not collapse in the favourites tab.

Comment 10

[Rick]

(In reply to rick.staa from comment #9)

(In reply to Mike Hommey [:glandium] from comment #8)

Oh, the screencast does look like Unity. Gnome Shell has something similar, but as far as testing on my machine goes, there is no "Add to Favorites" menu item when running Firefox from a downloaded mozilla.org build. It seems to rely on a .desktop file existing. So maybe this bug is an issue with the .desktop file shipped in whatever package you're using? (presumably, StartupWMClass)

(In reply to :Gijs (he/him) from comment #6)

I have no idea how Ubuntu deals with "Favorites" but it's unrelated to Firefox's own toolbars (which is what this component is for).

Hopefully our gtk/linux integration experts have more of an idea (though I'm not sure if widget is the best place for this, either - it would be on Windows, as taskbar groupings are controlled through our widget code...). If I had to guess, I'd expect the issue is to do with either .desktop files or the firefox wrapper script around firefox-bin, or something. :glandium, perhaps you know?

Dear Gijs and Mike. Thanks a lot for looking into the issue. The env | grep XDG_CURRENT_DESKTOP command gives the following output XDG_CURRENT_DESKTOP=ubuntu:GNOME. I also noticed that there is not "Add to Favorites" menu item when running Firefox nightly. I, therefore, used the "Show applications" tab to add Firefox nightly to favourites. I think this is where things go wrong as the new favourites toolbar icon now links to another firefox profile than my default firefox profile. As a result, when I open Firefox, it does not collapse in the favourites tab.

As a result this means that when using the downloaded version as there is no .desktop icon I can not add firefox to favorites without creating a .desktop icon myself. The wrong way of creating a favorites descrived described above is related to this method if installing firefox nightly.

Comment 11

[Rick]

(In reply to Mike Hommey [:glandium] from comment #8)

Oh, the screencast does look like Unity. Gnome Shell has something similar, but as far as testing on my machine goes, there is no "Add to Favorites" menu item when running firefox from a downloaded mozilla.org build. It seems to rely on a .desktop file existing. So maybe this bug is an issue with the .desktop file shipped in whatever package you're using? (presumably, StartupWMClass)

(In reply to :Gijs (he/him) from comment #6)

I have no idea how Ubuntu deals with "Favorites" but it's unrelated to Firefox's own toolbars (which is what this component is for).

Hopefully our gtk/linux integration experts have more of an idea (though I'm not sure if widget is the best place for this, either - it would be on Windows, as taskbar groupings are controlled through our widget code...). If I had to guess, I'd expect the issue is to do with either .desktop files or the firefox wrapper script around firefox-bin, or something. :glandium, perhaps you know?

Don't know what changed but the problem seems to be resolved on nightly version 74.0a1 (2020-01-24) (64-bit) (canonical 1.0).

Comment 12

[:Gijs (away/busy until Mar 10)]

Resolving per comment #11. Thanks!