Closed Bug 1602363 Opened 1 year ago Closed 1 year ago

Let Cross-Origin-Resource-Policy ride the trains

Categories

(Core :: DOM: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: annevk, Assigned: valentin)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [necko-triaged])

Attachments

(2 files)

I think it would be good to let this ride the trains so we can remove browser.tabs.remote.useCORP and reduce the number of features simultaneously in flight for "resab" somewhat.

What's needed:

  1. An intent to ship.
  2. Guarding the "cross-origin" value behind browser.tabs.remote.useCrossOriginEmbedderPolicy if that isn't the case already.
  3. A follow-up bug to remove browser.tabs.remote.useCORP after 1 or 2 releases.

Valentin, is this something you'd be interested in? (If there are any reasons this hasn't shipped yet that I might not know about, please do let me know. I'm not entirely sure why this wasn't shipped directly.)

Flags: needinfo?(valentin.gosu)

(In reply to Anne (:annevk) from comment #0)

Valentin, is this something you'd be interested in? (If there are any reasons this hasn't shipped yet that I might not know about, please do let me know. I'm not entirely sure why this wasn't shipped directly.)

I don't have time for it this week, and I go on PTO next week. If it's OK I can get on this on Jan 6th.
There aren't any blockers to this from what I know.

Flags: needinfo?(valentin.gosu)
Whiteboard: [necko-triaged]

That seems fine to me, thanks!

Assignee: nobody → valentin.gosu
Priority: -- → P2

(In reply to Anne (:annevk) from comment #0)

  1. Guarding the "cross-origin" value behind browser.tabs.remote.useCrossOriginEmbedderPolicy if that isn't the case already.

Uh, can you specify what you mean by this? Currently we do this

For cross-origin or null (or invalid content) we just let the request pass through (https://mikewest.github.io/corpp/#corp-check step 7)

Flags: needinfo?(annevk)

Oh I see, I forgot how that was put together. Sorry! I've crossed out 2 in comment 0.

Flags: needinfo?(annevk)
Blocks: 1609078

MDN needs to be updated to reflect that we're shipping this is Fx74

Keywords: dev-doc-needed
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/79bce5e9d341
Let Cross-Origin-Resource-Policy ride the trains r=annevk
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e656a857b8c6
Also pref on Cross-Origin-Resource-Policy for Android r=annevk
You need to log in before you can comment on or make changes to this bug.