1602468 - Toolbox destruction is doing too much work

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

When destroying the toolbox, we also destroy the browsing context front and all the fronts tree, which can take some time to be done.

We should check in this bug if all those destroy are needed, and if not, have an early return mechanism for the toolbox destruction.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1602468 - Skip destroy for object fronts on Toolbox destroy

Depends on D56527

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1602468 - Skip destroy for *ALL* fronts on Toolbox destroy

Depends on D56546

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aa0213b5603
Skip destroy for object fronts on Toolbox destroy r=ochameau,nchevobbe

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on framework/toolbox.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1f395d5f063e56749061c2ee773e9ede9104b80e
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294548902&repo=autoland&lineNumber=1316

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd2bb1ad6ccb
Skip destroy for object fronts on Toolbox destroy r=ochameau,nchevobbe

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cd2bb1ad6ccb