1602483 - CheckLoadURI failures should be reported to the web console as needed

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we don't do that because we don't oass in a window id to the error reporting.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1602483 part 1. Add a window id argument to SetupRefreshURIFromHeader. r=ckerschb

We can use this for error reporting.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1602483 part 2. Add a window id argument to CheckLoadURIWithPrincipal. r=ckerschb

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9be3269d781d
part 1.  Add a window id argument to SetupRefreshURIFromHeader.  r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/6b057ba06b4a
part 2.  Add a window id argument to CheckLoadURIWithPrincipal.  r=ckerschb

Comment 4

[Andrei Ciure[:aciure]]

Backed out 4 changesets (bug 1602483, bug 1602090) for causing perma leackchecks

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=e3e2c1d7478e450e2b32c85c416ccf70f9de56d3&selectedJob=280891198

backout: https://hg.mozilla.org/integration/autoland/rev/3bc1b1922126f73bb25b0b1ae0d6dab7e164116d

Comment 5

[Boris Zbarsky [:bzbarsky]]

We hit a pre-existing leak in the devtools code. Bug 1603666 is tracking fixing that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ed047bf1570
part 1.  Add a window id argument to SetupRefreshURIFromHeader.  r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/822078e02e7a
part 2.  Add a window id argument to CheckLoadURIWithPrincipal.  r=ckerschb

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6ed047bf1570
https://hg.mozilla.org/mozilla-central/rev/822078e02e7a