1602533 - moz-phab chokes on empty files in commit

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P1)

Description

[Yaron Tausky [:ytausky]]

When trying to submit a commit with an empty file I got the following error:

ERROR    2019-12-09 19:08:15,061 Traceback (most recent call last):
  File "/usr/local/bin/moz-phab", line 5084, in main
    args.func(repo, args)
  File "/usr/local/bin/moz-phab", line 4247, in submit
    diff = repo.get_diff(commit)
  File "/usr/local/bin/moz-phab", line 3413, in get_diff
    self._parse_diff_change(raw_change, diff)
  File "/usr/local/bin/moz-phab", line 3321, in _parse_diff_change
    if not lines[-1].endswith("\n"):
IndexError: list index out of range

Adding a \n to the file solved the problem.

Comment 1

[Piotr Zalewa [:zalun]]

Confirmed

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Bug 1602533 - Allow to submit empty files. r=mhentges