1602562 - Check for JS_CODE_COVERAGE_OUTPUT_DIR when black-listing jit-tests for coverage builds.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

We currently check at [1] for the GCOV_PREFIX environment variable in order to set the expected failures for jit-tests. While automation does set that prefix, a more appropriate variable to check is JS_CODE_COVERAGE_OUTPUT_DIR which is what triggers jsshell to test coverage and thus what causes the test failures.

[1] https://searchfox.org/mozilla-central/rev/23d4bffcad365e68d2d45776017056b76ca9a968/js/src/jit-test/jit_test.py#262

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1602562 - Use JS_CODE_COVERAGE_OUTPUT_DIR to blacklist jit-tests. r?nbp

These tests are expected failures when coverage is running. Currently we
check for GCOV_PREFIX environment variable, but JS_CODE_COVERAGE_OUTPUT_DIR
is the one that actually affects results.

Most of the failures are due to coverage disabling lazy parsing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e13d385cab9
Use JS_CODE_COVERAGE_OUTPUT_DIR to blacklist jit-tests. r=nbp

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2e13d385cab9